Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to done_acquiring #974

Closed
wants to merge 1 commit into from
Closed

Add logging to done_acquiring #974

wants to merge 1 commit into from

Conversation

NobodyXu
Copy link
Collaborator

No description provided.

@NobodyXu
Copy link
Collaborator Author

@chen-hongzhi can you try this patch and provide me with the output of build.rs please?

Thank you!

@chen-hongzhi
Copy link

chen-hongzhi commented Feb 25, 2024

I believe the issue is here:

if unsafe { libc::fcntl(fd, libc::F_SETFL, flags | libc::O_NONBLOCK) } == -1 {

It leads to no unset O_NONBLOCK.

@NobodyXu
Copy link
Collaborator Author

Thank you so much, looks like I forgot to update it when copy pasing the code!

We really need more maintainers for cc, to spot the mistakes I'm making.

@NobodyXu NobodyXu closed this Feb 25, 2024
@NobodyXu NobodyXu deleted the NobodyXu-patch-2 branch February 25, 2024 06:39
@NobodyXu NobodyXu restored the NobodyXu-patch-2 branch February 26, 2024 23:11
@NobodyXu NobodyXu deleted the NobodyXu-patch-2 branch February 27, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants