Move RawTableInner and TableLayout to separate module
#472
+505
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #470) made this pull request unmergeable. Please resolve the merge conflicts. |
JustForFun88
force-pushed
the
new_raw_table_inner_mod
branch
from
c73a928 to
97710e5
Compare
|
I'm not really a fan of splitting up code just for the safe of safety, but in this case the I am somewhat concerned about the compile-time impact of so many additional inline functions. Could you do a rustc perf run (using a PR on rust-lang/rust) to check that no compile-time regressions will occur once the standard library is updated to use the latest hashbrown? |
|
☔ The latest upstream changes (presumably #501) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All methods of the RawTableInner structure assume one important detail that is not described in the documentation: the
ctrlandbucket_maskfields must remain unchanged throughout the life of the currentRawTableInnerinstance. And this is without taking into account the specific requirements for thectrlandbucket_maskfields.Describing these requirements in each individual method will only lead to needlessly bloated documentation, since rustс has no way to block changing the individual fields of structure, and there is no way to check that they have not been changed.
To provide the minimum possible protection against changing the fields, we can only declare structures in a separate module, making necessary fields private.
Since the functions for getting the
bucket_maskare marked as#[inline(always)]this should not affect compilation speed or performance.But in general, this pull request just improves safety a little, fell free to close it if you don't like this idea.