sysconf interception fix for solarish systems. #4052
Draft
+89
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adding the `_SC_PAGESIZE` alias `_SC_PAGE_SIZE` supported by Linux, macOS and FreeBSD. close rust-lang#4050
RalfJung
reviewed
Nov 22, 2024
src/shims/unix/foreign_items.rs
Outdated
| @@ -394,13 +394,14 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> { | |||
| } | |||
|
|
|||
| // Querying system information | |||
| "sysconf" => { | |||
| "sysconf" | "__sysconf_xpg7" => { | |||
There was a problem hiding this comment.
__sysconf_xpg7 is not a standard name, is it? We should only support that on targets where it makes sense, i.e., Solaris.
There was a problem hiding this comment.
but neither is __xpg_strerror_r no ?
There was a problem hiding this comment.
Probably not, no -- we should do a similar check there. Just because we were sloppy in the past doesn't mean we should add more such things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adding the
_SC_PAGESIZEalias_SC_PAGE_SIZEsupported by Linux, macOS and FreeBSD.close #4050