Verify code generation of the AVX-512 rotates #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
adds an internal
verify/crate that usesstdsimd-test'sassert_instrmacro to disassembly functions at run-time and verify the generated assembly.it adds the verification for the AVX-512 vector rotates (initally in add rotate_left/right stdarch#496, but put on hold due to the migration to packed_simd).
cc @TheIronBorn I hope I did not miss anything. I managed to get the variable rotates working correctly. The reason they were failing is that you were passing the "variable" argument as an immediate. Instead of hardcoding it I just added it as a function argument, and in that case the right instruction is generated.