Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update destructors.md #1471

Closed
wants to merge 3 commits into from
Closed

Update destructors.md #1471

wants to merge 3 commits into from

Conversation

Tbkhi
Copy link

@Tbkhi Tbkhi commented Feb 17, 2024

@Tbkhi
Copy link
Author

Tbkhi commented Mar 6, 2024

CC: @mbrubeck

@Tbkhi
Copy link
Author

Tbkhi commented Mar 8, 2024

CC; @ehuss

@Tbkhi
Copy link
Author

Tbkhi commented Mar 9, 2024

Oops this will need to be fixed up.

@@ -104,6 +104,26 @@ dropped last when evaluating the function. Each actual function parameter is
dropped after any bindings introduced in that parameter's pattern.

```rust
// entire function scope begins
Copy link

@jdahlstrom jdahlstrom Apr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First letter should be capitalized unless it's an identifier, for correctness and consistency with other Rust documentation (including this file). Ditto for all the other comments.

@traviscross
Copy link
Contributor

We're discussing this in the rustdocs call. We're a bit unclear on the motivation for this change. If you could describe here in more detail what should be changed here, why, and why the change proposed is the right way to address it, that would be helpful.

Also, we note that the PR should be rebased and squashed.

@ehuss ehuss added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Jul 9, 2024
@ehuss
Copy link
Contributor

ehuss commented Feb 25, 2025

I'm going to close. I think we will eventually put some more work into the examples on drop scopes, but we're unsure exactly what it might look like. Thanks for the contribution!

@ehuss ehuss closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants