refactor: De-arc defmap queries #19707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-kqkpzkymkyyl
branch
2 times, most recently
from
ec4c530 to
6701f1f
Compare
Veykril
commented
Apr 28, 2025
Comment on lines
+378
to
+379
| #[allow(unused_lifetimes)] | ||
| mod __ { |
There was a problem hiding this comment.
This is to workaround the salsa issue
Veykril
force-pushed
the
push-kqkpzkymkyyl
branch
2 times, most recently
from
f105dd7 to
94fe906
Compare
|
Did we decide that we want queries to move to freestanding functions? |
|
Not but this was easier to do here. Though having done this, I feel like free functions aren't so bad? It feels like we should be wrapping most queries via some method on a related type instead of on the database? |
I like that approach! |
Veykril
force-pushed
the
push-kqkpzkymkyyl
branch
from
94fe906 to
d694cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a salsa bug that causes an unused lifetime lint