Skip to content

Commit

Permalink
Auto merge of #13230 - kyoto7250:fix_issue_13099, r=flip1995
Browse files Browse the repository at this point in the history
Add a test for ice-3717.rs

this PR is a part of #13099.

Based on the changes introduced in #13098 for introduce ui_test, we will update the uitest output.
This is a fix for `ice-3717.rs`.

Although fixes have already been made in #13216, it seems that he is a first-time contributor.
I thought it might be better for him to refer to my PR, so I created it accordingly.

Since this is my first contribution in a while, please let me know if there are any issues or required changes.

changelog:
None

r! `@flip1995`
  • Loading branch information
bors committed Aug 12, 2024
2 parents 1984752 + 5e25e7c commit a616ca7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
11 changes: 11 additions & 0 deletions tests/ui/crashes/ice-3717.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#![deny(clippy::implicit_hasher)]

use std::collections::HashSet;

fn main() {}

pub fn ice_3717<S: ::std::hash::BuildHasher + Default>(_: &HashSet<usize, S>) {
//~^ ERROR: parameter of type `HashSet` should be generalized over different hashers
let _ = [0u8; 0];
let _: HashSet<usize> = HashSet::default();
}
2 changes: 0 additions & 2 deletions tests/ui/crashes/ice-3717.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#![deny(clippy::implicit_hasher)]

//@no-rustfix: need to change the suggestion to a multipart suggestion

use std::collections::HashSet;

fn main() {}
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/crashes/ice-3717.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: parameter of type `HashSet` should be generalized over different hashers
--> tests/ui/crashes/ice-3717.rs:9:21
--> tests/ui/crashes/ice-3717.rs:7:21
|
LL | pub fn ice_3717(_: &HashSet<usize>) {
| ^^^^^^^^^^^^^^
Expand Down

0 comments on commit a616ca7

Please sign in to comment.