feat: lint against transmute int to ptr #13192
Draft
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
csmoe
force-pushed
the
fix/transmute-int-to-ptr
branch
2 times, most recently
from
f00f10a to
f10e731
Compare
csmoe
force-pushed
the
fix/transmute-int-to-ptr
branch
from
f10e731 to
ee73189
Compare
Alexendoo
reviewed
Jul 31, 2024
Comment on lines
+1
to
+8
| error: transmute from a `usize` to a pointer | ||
| --> tests/ui/transmute_int_to_ptr.rs:11:22 | ||
| | | ||
| LL | let x = unsafe { std::mem::transmute::<K1, *mut i8>(k) }; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: `-D clippy::wrong-transmute` implied by `-D warnings` | ||
| = help: to override `-D warnings` add `#[allow(clippy::wrong_transmute)]` |
There was a problem hiding this comment.
I think this should be a new lint with more specific diagnostics mentioning that it's UB to dereference the pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13140
changelog: make [
wrong_transmute] lint cover transmute_int2ptr