Do not recurse forever in significant_drop_tightening
#14641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
S-waiting-on-review
Limit the recursion depth, as each level of nesting adds another deeper projection.
samueltardieu
force-pushed
the
significant-drop-tightening-recursion-limit
branch
from
dd26f17 to
cc6a3d8
Compare
|
Assigning to Timo who diagnosed the problem in the original issue r? @y21 |
|
Ah, I just replied to the issue with how we could probably fix this and then saw this PR and does it exactly that way, nice ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the recursion depth, as each level of nesting adds another deeper projection.
There might be a more complex way of handling the problem, but infinite recursions are bad, and don't allow Clippy to terminate properly.
changelog: [
significant_drop_tightening]: do not recurse forever when checking for attribute on type or its constituentFixes #13544
@rustbot label +L-nursery