Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
windows-gnu
targets.stderr
/stdout
reference files use the expected line endings.Summary
First of all, the
windows-gnu
targets cannot currently build compiler plugins rust-lang/rust#47029. These targets are disabled temporarily.The big failure seems to be in how git checkout will convert the newlines in the stderr reference files into CRLF. This is countered by forcing LF line endings through
.gitattributes
.There is still one final issue that I have yet to fix. For some reason the CRLF difference (I believe) affects the Clippy output in specific scenarios. This results in extra newlines in the stderr output.
A selected example from the
needless_continue.rs
below. The// [...]
comments are added.Windows, pasted Playground:
Linux, gist Playground
Note the issue can be replicated in playground when pasting code there in Windows. Looking at the JSON payload this does include
\r\n
linebreaks in the HTTP request.I would love some pointers on where to look for that last issue.
The branch also builds on top of the #2333 to make it compile on the new Nightly to begin with.