Skip to content

WIP: Fix Appveyor CI build #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Rantanen
Copy link
Contributor

@Rantanen Rantanen commented Jan 7, 2018

Tasks

  • Temporarily disable windows-gnu targets.
  • Ensure stderr/stdout reference files use the expected line endings.
  • Fix the line ending -related difference in clippy reports.

Summary

First of all, the windows-gnu targets cannot currently build compiler plugins rust-lang/rust#47029. These targets are disabled temporarily.

The big failure seems to be in how git checkout will convert the newlines in the stderr reference files into CRLF. This is countered by forcing LF line endings through .gitattributes.

There is still one final issue that I have yet to fix. For some reason the CRLF difference (I believe) affects the Clippy output in specific scenarios. This results in extra newlines in the stderr output.

A selected example from the needless_continue.rs below. The // [...] comments are added.

Windows, pasted Playground:

           if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
               continue;
           }

           println!("Blabber");
           println!("Jabber");
           ...

Linux, gist Playground

   = help: Consider dropping the else clause, and moving out the code in the else block, like so:
           if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
               continue;
           }
           println!("Blabber");
           println!("Jabber");
           ...

Note the issue can be replicated in playground when pasting code there in Windows. Looking at the JSON payload this does include \r\n linebreaks in the HTTP request.

I would love some pointers on where to look for that last issue.


The branch also builds on top of the #2333 to make it compile on the new Nightly to begin with.

@Rantanen Rantanen changed the title Fix Appveyor CI build WIP: Fix Appveyor CI build Jan 7, 2018
@Rantanen
Copy link
Contributor Author

Rantanen commented Jan 7, 2018

Hm. Actually I've got no idea where this PR is going.

The test failures I'm receiving locally are not the same that AppVeyor reports. The windows-gnu failure is a valid fix, but the remaining ones Appveyor doesn't need.

@Rantanen Rantanen closed this Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant