Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation mode #287

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

presentation mode #287

wants to merge 4 commits into from

Conversation

timglabisch
Copy link

i created a minimalistic presentation mode.
most time if i give talks about languages i embed a live editor like the rust-playground.

when i tryed to embed the rust playground in my slides, i had some issues (small font, large header, ...).

the presentation mode is designed to be embedded as iframe to presentations.
http://127.0.0.1:5000/?pageMode=presentation&code=example_code

for example slides like https://ashleygwilliams.github.io/a-very-brief-intro-to-rust/#18 could directly embed the rust playpen.

presentation_mode

please review carefully, first time typescript and redux for me ;)

@shepmaster
Copy link
Member

Thanks! A fair warning, but we are doing some UI rework in another branch (haven't gotten to a PR yet) which will probably get merged first, so there might end up being some conflicts. I'm also expecting a baby 👶 in the next few weeks, so there's a possibility it might be a little while before I have time to cycle back to this! If I don't respond within... I dunno, a month, please ping me to remind me!

In the meantime, there's some small lint errors. You can see them locally by running yarn test:lint.

@timglabisch
Copy link
Author

@shepmaster i updated the PR :)

@tgross35
Copy link
Contributor

@timglabisch I'm interested in this feature as well... have you considered updating it to work with the new layout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants