-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visit enum init when the enum variable doesn't have any parameters #103506
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
This diagnostic is already reported in a very similar case struct S(u8, u8);
fn main() {
let _: S = S;
}
, and it's not specific to tuple structs, it works for any function calls returning the expected type. But for some reason it's not reported in cases like this struct S(u8, u8);
fn main() {
let S(_, _) = S;
}
I think we need to figure out why this |
2fc3699
to
7264b68
Compare
☔ The latest upstream changes (presumably #103636) made this pull request unmergeable. Please resolve the merge conflicts. |
@lyming2007 FYI: when a PR is ready for review, send a message containing |
petrochenkov was right about his comment. There was a similar case. But they're actually very different in terms of implementation. My fix was straight forward but maybe not a perfect one. So I still need more work on this. I'll update it later |
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. @rustbot label: +S-inactive |
this fix #101208