Fixes ICE in sparc64 ABI (Issue #115399)

[psumbera]

Fixes #115399

[rustbot]

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

[TaKO8Ki]

We don't need to add a test for this?

[psumbera]

We don't need to add a test for this?

I hope test isn't necessary.

[TaKO8Ki]

@psumbera In my opinion, it would be great to add a ui test like this. Could you add it?

rust/tests/ui/abi/compatibility.rs

Line 22 in a04d56b

//[sparc64] compile-flags: --target sparc64-unknown-linux-gnu

[psumbera]

@psumbera In my opinion, it would be great to add a ui test like this. Could you add it?

rust/tests/ui/abi/compatibility.rs

Line 22 in a04d56b

//[sparc64] compile-flags: --target sparc64-unknown-linux-gnu

I think I will need some help with it. The issue was that rustc hit assertion during compilation with certain rust code. What exactly should I do?

[TaKO8Ki]

@psumbera Could you read this documentation?

https://rustc-dev-guide.rust-lang.org/tests/ui.html

[rust-log-analyzer]

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_0ceb0206-a983-4977-b8c3-da3a7e3790a5
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=sparc-abi-fix3
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_0ceb0206-a983-4977-b8c3-da3a7e3790a5
GITHUB_REF=refs/pull/118611/merge
GITHUB_REF_NAME=118611/merge
GITHUB_REF_PROTECTED=false
---
Built container sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Looks like docker image is the same as before, not uploading
https://ci-caches.rust-lang.org/docker/7ebc15c01a233894034d277c8cce4e949f4e7791f66b4727c8fb6e058a0b8171d6152e1441d677cef0653843ceeee469c097b8699b2bb74249e674f6aa1a8813
sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-16]
##[group]Clock drift check
  local time: Thu Dec  7 15:39:29 UTC 2023
  network time: Thu, 07 Dec 2023 15:39:29 GMT
  network time: Thu, 07 Dec 2023 15:39:29 GMT
##[endgroup]
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-16', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-missing-tools', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-16/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: rust.codegen-units-std := 1
---
   Compiling bitflags v2.4.0
   Compiling linux-raw-sys v0.4.5
   Compiling fastrand v2.0.0
   Compiling smallvec v1.10.0
error: invalid `--check-cfg` argument: `values(freebsd10)` (expected `cfg(name, values("value1", "value2", ... "valueN"))`)
error: could not compile `libc` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:10:40
  local time: Thu Dec  7 15:50:43 UTC 2023

[Dylan-DPC]

@psumbera any updates on this? thanks

[psumbera]

@psumbera any updates on this? thanks

Unfortunatelly no. The proposed fix doesn't seem to cover all situations as mentioned here:
#115399 (comment)

Since then I haven't got enough time to focus on the issue.

(if it's matter we can close this pull request for now, while the bug remains open)

[Dylan-DPC]

Closing this as author has said they don't have time to complete this and current solution isn't acceptable