-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] adapt the default data-layout for aarch64 following llvm change #124801
Closed
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
llvm-main
Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling)
labels
May 6, 2024
This comment has been minimized.
This comment has been minimized.
krasimirgg
force-pushed
the
llvm-19-aarch-dl
branch
from
May 6, 2024 14:51
cd388d9
to
c3e6e11
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
@rustbot label: -llvm-main |
rustbot
removed
the
llvm-main
Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling)
label
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project@ddecada updated the default aarch64 data-layout. The mismatch can be seen at the rust + llvm @ head CI:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/27933#018f4d59-5008-4c38-ad98-9281c8d661d4/822-823
For rust, we might need something in the spirit of #116672. This is a quick-and-incomplete fix to try and patch the CI in the meantime.
@rustbot label: +llvm-main