Mangle rustc_std_internal_symbols functions

[bjorn3]

This reduces the risk of issues when using a staticlib or rust dylib compiled with a different rustc version in a rust program. Currently this will either (in the case of staticlib) cause a linker error due to duplicate symbol definitions, or (in the case of rust dylibs) cause rustc_std_internal_symbols functions to be silently overridden. As rust gets more commonly used inside the implementation of libraries consumed with a C interface (like Spidermonkey, Ruby YJIT (curently has to do partial linking of all rust code to hide all symbols not part of the C api), the Rusticl OpenCL implementation in mesa) this is becoming much more of an issue. With this PR the only symbols remaining with an unmangled name are rust_eh_personality (LLVM doesn't allow renaming it) and __rust_no_alloc_shim_is_unstable.

Helps mitigate #104707

try-job: aarch64-gnu-debug
try-job: aarch64-apple
try-job: x86_64-apple-1
try-job: x86_64-mingw-1
try-job: i686-mingw-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: test-various
try-job: armhf-gnu

[rustbot]

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[bors]

☔ The latest upstream changes (presumably #127162) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[fee1-dead]

r? compiler

[bjorn3]

Opened rust-lang/miri#3724 with some miri changes that can be made independently of this PR.

[bors]

☔ The latest upstream changes (presumably #125507) made this pull request unmergeable. Please resolve the merge conflicts.

[bjorn3]

Changed the test to only run on Linux. It isn't reasonable to exhaustively list every unmangled symbol that the platform toolchain may add.

@rustbot ready

[jieyouxu]

Two nits, then feel free to r= Wesley and me.

[jieyouxu]

@rustbot author

[bjorn3]

@bors r=wesleywiser,jieyouxu

[bors]

📌 Commit e377765 has been approved by wesleywiser,jieyouxu

It is now in the queue for this repository.

[jieyouxu]

@bors p=6 (threading between rollups)

[matthiaskrgr]

@bors p=0 lets not do that, we already have around 70 PRs in queue and should make some progress to get that down a bit

[bors]

⌛ Testing commit e377765 with merge 0d8f13a...

[bors]

💔 Test failed - checks-actions

[bjorn3]

I can't reproduce this locally on arm64 linux. Neither with nor without lld.

[jieyouxu]

I can't reproduce this locally on arm64 linux. Neither with nor without lld.

I'm not 100% sure, but maybe this symbol comes from LLVM compiler-rt?

https://github.com/llvm/llvm-project/blob/794ba171a43baaf9de9739440ddb582500527031/compiler-rt/lib/builtins/cpu_model/aarch64.c#L59-L64

Though the symbol visibility of that is hidden so idk.

[bjorn3]

Though the symbol visibility of that is hidden so idk.

Looks like symbol.is_global() doesn't take symbol visibility into account, just linkage.

I've changed symbols_check to ignore symbols that don't have rust in the name, but keep symbols_check_archive check all symbols. I've also changed the test back to running on all targets.

[jieyouxu]

That seems reasonble. I'd like to see if there's any nasty surprises since the queue is currently backed up a lot, so

@bors try

[bors]

⌛ Trying commit bf70cce with merge 6255ed0...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Updating files:  98% (51242/52287)
Updating files:  99% (51765/52287)
Updating files: 100% (52287/52287)
Updating files: 100% (52287/52287), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format=%H
6255ed0489eeefaa2719bb0dd42337672839b069
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
---- [run-make] tests\run-make\symbols-all-mangled stdout ----

error: rmake recipe failed to complete
status: exit code: 101
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\symbols-all-mangled\\rmake.exe"
--- stderr -------------------------------

thread 'main' panicked at D:\a\rust\rust\tests\run-make\symbols-all-mangled\rmake.rs:43:9:
thread 'main' panicked at D:\a\rust\rust\tests\run-make\symbols-all-mangled\rmake.rs:43:9:
Unmangled symbol found: .refptr._RNvCsjWV00SMt6BG_7___rustc39___rust_alloc_error_handler_should_panic
------------------------------------------




failures:
    [run-make] tests\run-make\symbols-all-mangled

test result: FAILED. 276 passed; 1 failed; 103 ignored; 0 measured; 6 filtered out; finished in 210.54s

Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:30:36
make: *** [Makefile:126: ci-mingw-x] Error 1
  network time: Tue, 04 Mar 2025 19:37:14 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions