Rollup of 7 pull requests #129563

matthiaskrgr · 2024-08-25T14:51:07Z

Successful merges:

add Box::as_ptr and Box::as_mut_ptr methods #129091 (add Box::as_ptr and Box::as_mut_ptr methods)
bootstrap: improve error recovery flags to curl #129134 (bootstrap: improve error recovery flags to curl)
library: Move unstable API of new_uninit to new features #129416 (library: Move unstable API of new_uninit to new features)
handle stage0 cargo and rustc separately #129459 (handle stage0 cargo and rustc separately)
repr_transparent_external_private_fields: special-case some std types #129487 (repr_transparent_external_private_fields: special-case some std types)
Update minifier to 0.3.1 #129511 (Update minifier to 0.3.1)
Make rustc_type_ir build on stable #129523 (Make rustc_type_ir build on stable)

r? @ghost
@rustbot modify labels: rollup

alternative to rust-lang#128459 fixes rust-lang#110178

This change allows setting either `build.cargo` or `build.rustc` without requiring both to be set simultaneously, which was not possible previously. To try it, set `build.rustc` without setting `build.cargo`, and try to bootstrap on clean build. Signed-off-by: onur-ozkan <[email protected]>

- `new_zeroed` variants move to `new_zeroed_alloc` - the `write` fn moves to `box_uninit_write` The remainder will be stabilized in upcoming patches, as it was decided to only stabilize `uninit*` and `assume_init`.

Link: rust-lang#129416 Signed-off-by: Miguel Ojeda <[email protected]>

…t` types as local

add Box::as_ptr and Box::as_mut_ptr methods Unstably implements rust-lang/libs-team#355. Tracking issue: rust-lang#129090. r? libs-api

bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? ````@Kobzol````

…tabilization, r=dtolnay library: Move unstable API of new_uninit to new features - `new_zeroed` variants move to `new_zeroed_alloc` - the `write` fn moves to `box_uninit_write` The remainder will be stabilized in upcoming patches, as it was decided to only stabilize `uninit*` and `assume_init`.

…=Kobzol handle stage0 `cargo` and `rustc` separately This change allows setting either `build.cargo` or `build.rustc` without requiring both to be set simultaneously, which was not possible previously. To try it, set `build.rustc` without setting `build.cargo`, and try to bootstrap on clean build. Blocker for rust-lang#129152

…rnal_private_fields, r=compiler-errors repr_transparent_external_private_fields: special-case some std types Fixes rust-lang#129470 ```@rustbot``` label +A-lint +L-repr_transparent_external_private_fields

…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ````@notriddle````

Make `rustc_type_ir` build on stable This PR fixes a handful of issues that appear in `rustc_type_ir` when trying to build the new solver on stable. r? ```@compiler-errors``` ```@bors``` rollup

matthiaskrgr · 2024-08-25T14:51:47Z

@bors r+ rollup=never p=7

bors · 2024-08-25T14:51:49Z

📌 Commit 86d5c53 has been approved by matthiaskrgr

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129091 (add Box::as_ptr and Box::as_mut_ptr methods) - rust-lang#129134 (bootstrap: improve error recovery flags to curl) - rust-lang#129416 (library: Move unstable API of new_uninit to new features) - rust-lang#129459 (handle stage0 `cargo` and `rustc` separately) - rust-lang#129487 (repr_transparent_external_private_fields: special-case some std types) - rust-lang#129511 (Update minifier to 0.3.1) - rust-lang#129523 (Make `rustc_type_ir` build on stable) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-25T17:10:16Z

⌛ Testing commit 86d5c53 with merge 705176d...

rust-log-analyzer · 2024-08-25T18:51:34Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.428
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Sun, Aug 25, 2024  6:51:20 PM
  network time: Sun, 25 Aug 2024 18:51:21 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-08-25T18:52:10Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-08-25T18:56:36Z

@bors retry

bors · 2024-08-25T20:29:36Z

⌛ Testing commit 86d5c53 with merge c6db1ca...

bors · 2024-08-25T22:53:06Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c6db1ca to master...

rust-timer · 2024-08-25T22:55:03Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129091	add Box::as_ptr and Box::as_mut_ptr methods	`fd54f60f23553262d63b273f84ecb4a505265c62` (link)
#129134	bootstrap: improve error recovery flags to curl	`07ec614fc2be779b42a0e3eab1b6aaf2eb50dd35` (link)
#129416	library: Move unstable API of new_uninit to new features	`9784044b90b997881e19c4c51c6136c669598f20` (link)
#129459	handle stage0 `cargo` and `rustc` separately	`31d20efc81e2b2507ad2eb21dc90d63a41df6735` (link)
#129487	repr_transparent_external_private_fields: special-case some…	`eeef9bd5b1a13cdfe64d913928e4625d506f1614` (link)
#129511	Update minifier to 0.3.1	`d5f4933d504dde20397f66fa5e2df203974f5420` (link)
#129523	Make `rustc_type_ir` build on stable	`1337227d5f473653fb11b9153867f353aca70d9b` (link)

previous master: 1a94d839be

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-08-26T00:08:37Z

Finished benchmarking commit (c6db1ca): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.1%, secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.0%, 1.2%]	2
Regressions ❌ (secondary)	2.2%	[2.2%, 2.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	1.1%	[1.0%, 1.2%]	2

Cycles

Results (secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.849s -> 749.497s (-0.45%)
Artifact size: 338.80 MiB -> 338.78 MiB (-0.00%)

RalfJung and others added 24 commits August 14, 2024 14:30

add Box::as_ptr and Box::as_mut_ptr methods

6eaf531

use the new Box methods in the interpreter

58dcd1c

bootstrap: improve error recovery flags to curl

12e6389

alternative to rust-lang#128459 fixes rust-lang#110178

autoformat and remove unit test

b3ec296

remove dbg!()

d1b41f3

use tuples for semver, not floats

69ca95b

library: Move unstable API of new_uninit to new features

9ccd7ab

- `new_zeroed` variants move to `new_zeroed_alloc` - the `write` fn moves to `box_uninit_write` The remainder will be stabilized in upcoming patches, as it was decided to only stabilize `uninit*` and `assume_init`.

CI: rfl: move to temporary commit

90b4e17

Link: rust-lang#129416 Signed-off-by: Miguel Ojeda <[email protected]>

Update minifier to 0.3.1

c36b563

New #[rustc_pub_transparent] attribute

b9033bd

repr_transparent_external_private_fields: treat `rustc_pub_transparen…

06f2d73

…t` types as local

only use rustc attr on nightly

300da9a

add missing associated item

3e2763a

this needs the type for some reason

ad855fe

allow cfg(bootstrap) to avoid check-cfg warning on stable

902264b

rewrite extract_curl_version again

56adf87

Rollup merge of rust-lang#129091 - RalfJung:box_as_ptr, r=Amanieu

7edbd63

add Box::as_ptr and Box::as_mut_ptr methods Unstably implements rust-lang/libs-team#355. Tracking issue: rust-lang#129090. r? libs-api

Rollup merge of rust-lang#129134 - lolbinarycat:continue-at, r=Kobzol

8e27d4c

bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? ````@Kobzol````

Rollup merge of rust-lang#129487 - GrigorenkoPV:repr_transparent_exte…

9c59e97

…rnal_private_fields, r=compiler-errors repr_transparent_external_private_fields: special-case some std types Fixes rust-lang#129470 ```@rustbot``` label +A-lint +L-repr_transparent_external_private_fields

Rollup merge of rust-lang#129511 - GuillaumeGomez:update-minifier, r=…

c6f7b1f

…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ````@notriddle````

Rollup merge of rust-lang#129523 - lqd:stable-type-ir, r=compiler-errors

86d5c53

Make `rustc_type_ir` build on stable This PR fixes a handful of issues that appear in `rustc_type_ir` when trying to build the new solver on stable. r? ```@compiler-errors``` ```@bors``` rollup

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 25, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2024

bors merged commit c6db1ca into rust-lang:master Aug 25, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 25, 2024

This was referenced Aug 25, 2024

Partially stabilize feature(new_uninit) #129401

Merged

Autodiff Upstreaming - enzyme frontend #129458

Merged

matthiaskrgr deleted the rollup-t6bai2d branch September 1, 2024 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #129563

Rollup of 7 pull requests #129563

matthiaskrgr commented Aug 25, 2024

matthiaskrgr commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 25, 2024

rust-log-analyzer commented Aug 25, 2024

bors commented Aug 25, 2024

matthiaskrgr commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 25, 2024

rust-timer commented Aug 25, 2024

rust-timer commented Aug 26, 2024

Rollup of 7 pull requests #129563

Rollup of 7 pull requests #129563

Conversation

matthiaskrgr commented Aug 25, 2024

matthiaskrgr commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 25, 2024

rust-log-analyzer commented Aug 25, 2024

bors commented Aug 25, 2024

matthiaskrgr commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 25, 2024

rust-timer commented Aug 25, 2024

rust-timer commented Aug 26, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size