-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle rustc_mir_dataflow
cases of rustc::potential_query_instability
lint
#131290
Handle rustc_mir_dataflow
cases of rustc::potential_query_instability
lint
#131290
Conversation
The current code is correct. It just needs a comment explaining why the |
r? @cjgillot |
So what can be the rationale; I can add it. |
The issue with
So the need is not to replace all containers, but rather to discriminate between cases that need replacement, from cases that don't need it. |
Hmm. I don't have the knowledge to do that I guess. |
@ismailarilik |
Let me check the last time. |
3c09e88
to
62c139e
Compare
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in src/tools/clippy cc @rust-lang/clippy These commits modify compiler targets. Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in match lowering cc @Nadrieril Some changes occurred in match checking cc @Nadrieril HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/cargo cc @ehuss The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@rustbot label -WG-trait-system-refactor |
62c139e
to
8adb4b3
Compare
This PR removes
#![allow(rustc::potential_query_instability)]
occurrences fromcompiler/rustc_mir_dataflow/
and convertsFxHash{Map,Set}
types intoFxIndex{Map,Set}
to suppress lint errors.A somewhat tracking issue: #84447
r? @compiler-errors