Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Free more disk space with free-disk-space script #134151

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

whiteio
Copy link

@whiteio whiteio commented Dec 10, 2024

Attempting to move the free-disk-space github action into the repo as it isn't currently maintained. This involves moving the script within free-disk-space into the repo.

I'm opening this as a draft to verify that the saved space is the same as the original action. Once that is verified, I'll look into integrating these two PRs to improve it:

Changes so far:

  • Took the script from the free-disk-space repo and moved it into src/ci/scripts/
  • Removed unnecessary if statements which were used to check for github action inputs which we don't need to check
  • Swapped to using this script within the rust repo, instead of using the jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be GitHub action

See this issue for more info: rust-lang/infra-team#183

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@whiteio
Copy link
Author

whiteio commented Dec 11, 2024

Confirmed that the script behaves the same when moved to the repo, still trying to figure out if jlumbroso/free-disk-space#26 makes a tangible difference.

Currently, free disk space can clean up 36GB with the changes up to this point, so a 10GB improvement so far.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@whiteio whiteio force-pushed the infra-issue-183 branch 2 times, most recently from 0850509 to e447a4f Compare December 12, 2024 00:19
@rust-log-analyzer

This comment has been minimized.

@larziwau
Copy link

e447a4f (#134151)
does this commit really make a difference?

@whiteio
Copy link
Author

whiteio commented Dec 13, 2024

e447a4f (#134151) does this commit really make a difference?

Nope, will be reverting that one, jlumbroso/free-disk-space#26 also doesn't seem to make a noticeable improvement, especially compared to the example in that PR

@whiteio whiteio force-pushed the infra-issue-183 branch 2 times, most recently from 5ef7bf7 to e0d0d4b Compare December 13, 2024 20:42
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants