-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPERIMENTAL] Something's Wrong I Can Feel It (x86_64 apple funny business) #134275
base: master
Are you sure you want to change the base?
Conversation
@bors try |
[EXPERIMENTAL] Something's Wrong I Can Feel It (x86_64 apple funny business) See rust-lang#134220 r? `@ghost` try-job: dist-x86_64-apple
☀️ Try build successful - checks-actions |
# XXX(jieyouxu): I want assertions | ||
#NO_LLVM_ASSERTIONS: 1 | ||
#NO_DEBUG_ASSERTIONS: 1 | ||
#NO_OVERFLOW_CHECKS: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is enough, because you still have DEPLOY
and not DEPLOY_ALT
here:
Lines 127 to 130 in 4847d6a
elif [ "$DEPLOY_ALT" != "" ]; then | |
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-assertions" | |
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir" | |
fi |
... and that's set automatically by the image name here:
rust/src/ci/scripts/setup-environment.sh
Lines 30 to 36 in 4847d6a
if [[ "${CI_JOB_NAME}" = *-alt ]]; then | |
echo "alternate dist builder detected, setting DEPLOY_ALT=1" | |
ciCommandSetEnv DEPLOY_ALT 1 | |
else | |
echo "normal dist builder detected, setting DEPLOY=1" | |
ciCommandSetEnv DEPLOY 1 | |
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a lil hack by changing the job name to dist-x86_64-apple-alt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also thank you for pointing this out, I would not have guessed otherwise
e29d81c
to
c8aff1d
Compare
@bors try |
[EXPERIMENTAL] Something's Wrong I Can Feel It (x86_64 apple funny business) See rust-lang#134220 r? `@ghost` try-job: dist-x86_64-apple-alt
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
See #134220
r? @ghost
try-job: dist-x86_64-apple-alt