Skip to content

Trusty: Implement write_vectored for stdio #138876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/std/src/sys/io/io_slice/iovec.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#[cfg(target_os = "hermit")]
use hermit_abi::iovec;
#[cfg(target_family = "unix")]
#[cfg(any(target_family = "unix", target_os = "trusty"))]
use libc::iovec;

use crate::ffi::c_void;
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/io/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

mod io_slice {
cfg_if::cfg_if! {
if #[cfg(any(target_family = "unix", target_os = "hermit", target_os = "solid_asp3"))] {
if #[cfg(any(target_family = "unix", target_os = "hermit", target_os = "solid_asp3", target_os = "trusty"))] {
mod iovec;
pub use iovec::*;
} else if #[cfg(target_os = "windows")] {
Expand Down
83 changes: 47 additions & 36 deletions library/std/src/sys/stdio/trusty.rs
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
use crate::io;
#[expect(dead_code)]
#[path = "unsupported.rs"]
mod unsupported_stdio;

pub struct Stdin;
use crate::cmp;
use crate::io::{self, IoSlice};

pub type Stdin = unsupported_stdio::Stdin;
pub struct Stdout;
pub struct Stderr;

impl Stdin {
pub const fn new() -> Stdin {
Stdin
}
}

impl io::Read for Stdin {
fn read(&mut self, _buf: &mut [u8]) -> io::Result<usize> {
Ok(0)
}
}

impl Stdout {
pub const fn new() -> Stdout {
Stdout
Expand All @@ -24,7 +17,16 @@ impl Stdout {

impl io::Write for Stdout {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
_write(libc::STDOUT_FILENO, buf)
write(libc::STDOUT_FILENO, buf)
}

fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> io::Result<usize> {
write_vectored(libc::STDOUT_FILENO, bufs)
}

#[inline]
fn is_write_vectored(&self) -> bool {
true
}

fn flush(&mut self) -> io::Result<()> {
Expand All @@ -40,15 +42,24 @@ impl Stderr {

impl io::Write for Stderr {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
_write(libc::STDERR_FILENO, buf)
write(libc::STDERR_FILENO, buf)
}

fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> io::Result<usize> {
write_vectored(libc::STDERR_FILENO, bufs)
}

#[inline]
fn is_write_vectored(&self) -> bool {
true
}

fn flush(&mut self) -> io::Result<()> {
Ok(())
}
}

pub const STDIN_BUF_SIZE: usize = 0;
pub const STDIN_BUF_SIZE: usize = unsupported_stdio::STDIN_BUF_SIZE;

pub fn is_ebadf(_err: &io::Error) -> bool {
true
Expand All @@ -58,24 +69,24 @@ pub fn panic_output() -> Option<impl io::Write> {
Some(Stderr)
}

fn _write(fd: i32, message: &[u8]) -> io::Result<usize> {
let mut iov = libc::iovec { iov_base: message.as_ptr() as *mut _, iov_len: message.len() };
loop {
// SAFETY: syscall, safe arguments.
let ret = unsafe { libc::writev(fd, &iov, 1) };
if ret < 0 {
return Err(io::Error::last_os_error());
}
let ret = ret as usize;
if ret > iov.iov_len {
return Err(io::Error::last_os_error());
}
if ret == iov.iov_len {
return Ok(message.len());
}
// SAFETY: ret has been checked to be less than the length of
// the buffer
iov.iov_base = unsafe { iov.iov_base.add(ret) };
iov.iov_len -= ret;
fn write(fd: i32, buf: &[u8]) -> io::Result<usize> {
let iov = libc::iovec { iov_base: buf.as_ptr() as *mut _, iov_len: buf.len() };
// SAFETY: syscall, safe arguments.
let ret = unsafe { libc::writev(fd, &iov, 1) };
// This check includes ret < 0, since the length is at most isize::MAX.
if ret as usize > iov.iov_len {
return Err(io::Error::last_os_error());
}
Ok(ret as usize)
}

fn write_vectored(fd: i32, bufs: &[IoSlice<'_>]) -> io::Result<usize> {
let iov = bufs.as_ptr() as *const libc::iovec;
let len = cmp::min(bufs.len(), libc::c_int::MAX as usize) as libc::c_int;
// SAFETY: syscall, safe arguments.
let ret = unsafe { libc::writev(fd, iov, len) };
if ret < 0 {
return Err(io::Error::last_os_error());
}
Ok(ret as usize)
}
Loading