Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target maintainer information for powerpc64-unknown-linux-musl #138905

Merged

Conversation

Gelbpunkt
Copy link
Contributor

@Gelbpunkt Gelbpunkt commented Mar 24, 2025

We intend to fix the outstanding issues on the target and eventually promote it to tier 2. We have the capacity to maintain this target in the future and already perform regular builds of rustc for this target.

Currently, all host tools except miri build fine, but I have a patch for libffi-sys to make miri also compile fine for this target that is pending review.

While at it, add an option for the musl root for this target.

I also added a kernel version requirement, which is rather arbitrarily chosen, but it matches our tier 2 powerpc64le-unknown-linux-musl target so I think it is a good fit.

We intend to fix the outstanding issues on the target and eventually
promote it to tier 2. We have the capacity to maintain this target in
the future and already perform regular builds of rustc for this target.

Currently, all host tools except miri build fine, but I have a patch for
libffi-sys to make miri also compile fine for this target that is
pending review [1].

While at it, add an option for the musl root for this target.

[1]: tov/libffi-rs#100

Signed-off-by: Jens Reidel <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@ehuss
Copy link
Contributor

ehuss commented Mar 24, 2025

r? compiler

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 24, 2025
@rustbot rustbot assigned lcnr and unassigned ehuss Mar 24, 2025
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 25, 2025

📌 Commit 1a8ddee has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang#138128 (Stabilize `#![feature(precise_capturing_in_traits)]`)
 - rust-lang#138834 (Group test diffs by stage in post-merge analysis)
 - rust-lang#138867 (linker: Fix staticlib naming for UEFI)
 - rust-lang#138874 (Batch mark waiters as unblocked when resuming in the deadlock handler)
 - rust-lang#138875 (Trusty: Fix build for anonymous pipes and std::sys::process)
 - rust-lang#138877 (Ignore doctests only in specified targets)
 - rust-lang#138885 (Fix ui pattern_types test for big-endian platforms)
 - rust-lang#138905 (Add target maintainer information for powerpc64-unknown-linux-musl)
 - rust-lang#138911 (Allow defining opaques in statics and consts)
 - rust-lang#138917 (rustdoc: remove useless `Symbol::is_empty` checks.)
 - rust-lang#138945 (Override PartialOrd methods for bool)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f6bfdff into rust-lang:master Mar 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2025
Rollup merge of rust-lang#138905 - Gelbpunkt:powerpc64-unknown-linux-musl-maintainer, r=compiler-errors

Add target maintainer information for powerpc64-unknown-linux-musl

We intend to fix the outstanding issues on the target and eventually promote it to tier 2. We have the capacity to maintain this target in the future and already perform regular builds of rustc for this target.

Currently, all host tools except miri build fine, but I have a patch for libffi-sys to make miri also compile fine for this target that is [pending review](tov/libffi-rs#100).

While at it, add an option for the musl root for this target.

I also added a kernel version requirement, which is rather arbitrarily chosen, but it matches our tier 2 powerpc64le-unknown-linux-musl target so I think it is a good fit.
@Gelbpunkt Gelbpunkt deleted the powerpc64-unknown-linux-musl-maintainer branch March 26, 2025 17:58
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang#138128 (Stabilize `#![feature(precise_capturing_in_traits)]`)
 - rust-lang#138834 (Group test diffs by stage in post-merge analysis)
 - rust-lang#138867 (linker: Fix staticlib naming for UEFI)
 - rust-lang#138874 (Batch mark waiters as unblocked when resuming in the deadlock handler)
 - rust-lang#138875 (Trusty: Fix build for anonymous pipes and std::sys::process)
 - rust-lang#138877 (Ignore doctests only in specified targets)
 - rust-lang#138885 (Fix ui pattern_types test for big-endian platforms)
 - rust-lang#138905 (Add target maintainer information for powerpc64-unknown-linux-musl)
 - rust-lang#138911 (Allow defining opaques in statics and consts)
 - rust-lang#138917 (rustdoc: remove useless `Symbol::is_empty` checks.)
 - rust-lang#138945 (Override PartialOrd methods for bool)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants