-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect an array when expected and acutal types are both arrays during cast #138962
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xizheyin <[email protected]>
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a description for why this code fixes the issue and especially why it's not going to affect existing code.
My first reaction to this code is definitely not the right way to fix a diagnostics issue, since it is code that is exercised even when there are no failures.
@rustbot author |
This is the handling of special circumstances. But I missed one condition. This function checks when cast If the type The example is shown in the corresponding issue and the ui test newly added. In this case, the code before and after modification will definitely report an error, so it will not affect the original logic. @compiler-errors |
… cast Signed-off-by: xizheyin <[email protected]>
Closing #138836