Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't suggest the use of impl Trait in closure parameter #138998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't suggest the use of impl Trait in closure parameter #138998

wants to merge 1 commit into from
+31 −6

Conversation

rperier
Copy link

@rperier rperier commented Mar 26, 2025 •
edited
Loading

Closing #138932

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rperier
Suggest the use of impl Trait in function parameter only
d280652 
Currently in case of a Trait object in closure parameter, the compiler
suggests either to use a reference, which is correct or to use an
`impl Trait` which is not. Do not emit this suggestion when the parameter
is part of a closure.
@rperier rperier force-pushed the donot_suggest_to_use_impl_trait_in_closure_params branch from 133718c to d280652 Compare March 27, 2025 17:46
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 27, 2025
@rperier
Copy link
Author

rperier commented Apr 4, 2025

r? rust-lang/diagnostics

@rustbot rustbot assigned estebank and unassigned Noratrieb Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rperier @rustbot @rust-log-analyzer @estebank @Noratrieb