Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default auto traits: fix perf #139365

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Default auto traits: fix perf #139365

merged 1 commit into from
Apr 7, 2025
+51 −35

Conversation

Bryanskiy
Copy link
Contributor

Skip computing requires_default_supertraits if experimental-default-bounds option is not enabled. Possible perf fix for #120706

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2025

HIR ty lowering was modified

cc @fmease

@Kobzol
Copy link
Contributor

Kobzol commented Apr 4, 2025

@bors try @rust-timre queue

@Kobzol
Copy link
Contributor

Kobzol commented Apr 4, 2025

@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 4, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2025
@bors
Auto merge of rust-lang#139365 - Bryanskiy:leak-perf, r=<try>
370f69e 
Default auto traits: fix perf

Skip computing `requires_default_supertraits` if `experimental-default-bounds` option is not enabled. Possible perf fix for rust-lang#120706

r? lcnr
@bors
Copy link
Collaborator

bors commented Apr 4, 2025

⌛ Trying commit 0522ed0 with merge 370f69e...

@bors
Copy link
Collaborator

bors commented Apr 4, 2025

☀️ Try build successful - checks-actions
Build commit: 370f69e (370f69e3775a724f2f59b943ec2474ade6e74e07)

@rust-timer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me on the change, waiting on perf

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (370f69e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.1% [-3.1%, -3.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 2
All ❌✅ (primary) - - 0

Bootstrap: 780.575s -> 780.154s (-0.05%)
Artifact size: 365.99 MiB -> 365.91 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 4, 2025
@petrochenkov
Copy link
Contributor

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Apr 7, 2025

📌 Commit 0522ed0 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 7, 2025
@Zalathar
Rollup merge of rust-lang#139365 - Bryanskiy:leak-perf, r=lcnr
a774360 
Default auto traits: fix perf

Skip computing `requires_default_supertraits` if `experimental-default-bounds` option is not enabled. Possible perf fix for rust-lang#120706

r? lcnr
@Zalathar Zalathar mentioned this pull request Apr 7, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@bors
Auto merge of rust-lang#139478 - Zalathar:rollup-jaate8v, r=Zalathar
81990dc 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#138603 (Report line number of test when should_panic test failed)
 - rust-lang#139035 (Add new `PatKind::Missing` variants)
 - rust-lang#139112 (Implement `super let`)
 - rust-lang#139365 (Default auto traits: fix perf)
 - rust-lang#139397 (coverage: Build the CGU's global file table as late as possible)
 - rust-lang#139455 ( Remove support for `extern "rust-intrinsic"` blocks)
 - rust-lang#139461 (Stop calling `source_span` query in significant drop order code)
 - rust-lang#139466 (Trivial tweaks to stop tracking source span directly)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Apr 7, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@bors
Auto merge of rust-lang#139482 - Zalathar:rollup-h2ht1y6, r=Zalathar
e643f59 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#139035 (Add new `PatKind::Missing` variants)
 - rust-lang#139108 (Simplify `thir::PatKind::ExpandedConstant`)
 - rust-lang#139112 (Implement `super let`)
 - rust-lang#139365 (Default auto traits: fix perf)
 - rust-lang#139397 (coverage: Build the CGU's global file table as late as possible)
 - rust-lang#139455 ( Remove support for `extern "rust-intrinsic"` blocks)
 - rust-lang#139461 (Stop calling `source_span` query in significant drop order code)
 - rust-lang#139465 (add sret handling for scalar autodiff)
 - rust-lang#139466 (Trivial tweaks to stop tracking source span directly)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4c429f into rust-lang:master Apr 7, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@rust-timer
Unrolled build for rust-lang#139365
74cf664 
Rollup merge of rust-lang#139365 - Bryanskiy:leak-perf, r=lcnr

Default auto traits: fix perf

Skip computing `requires_default_supertraits` if `experimental-default-bounds` option is not enabled. Possible perf fix for rust-lang#120706

r? lcnr
@Kobzol
Copy link
Contributor

Kobzol commented Apr 7, 2025

It doesn't seem like this actually fixed the perf. regression from #120706 though 🤔

@rylev rylev mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Bryanskiy @rustbot @Kobzol @rust-timer @bors @petrochenkov @lcnr