Rollup of 11 pull requests #139396
Merged
Rollup of 11 pull requests #139396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also makes `changeSetting` more robust in case it somehow gets called before `main.js` has finished loading.
changes: * Add type signature * Add null checks * getHelpButton and getSettingsButton are only called once, which should marginally improve performance due to less queries. unfortunatly 2 @ts-expect-error was needed, as typescript is unaware the EventTarget is likely an Element.
With this, almost the entire file is fully typechecked, the only exception being the Element.contains(EventTarget) pattern that is used several times, those are annotated with @ts-expect-error
"true" looks like a string value, `true` makes it more clear that we are talking about the actual boolean value.
this allows us to eliminate the last 3 @ts-expect-error in this file.
I accidentally added this in rust-lang#138740.
Fixes rust-lang#137874. Removes `tests/crashes/137874.rs`; the new test is simpler (defines its own macro) but tests the same thing. The changes to the output of `tests/ui/associated-consts/issue-93835.rs` partly undo the changes seen when `NtTy` was removed in rust-lang#133436, which is good.
replace extra_filename with strict version hash in metrics file names Should resolve the potential issue of overwriting metrics from the same crate when compiled with different features or flags. r? `````@estebank````` try-job: test-various
…t-error-part5, r=notriddle Rustdoc: typecheck settings.js This makes the file fully typechecked with no instances of ``````@ts-expect-error`````` and no type casts. r? `````@notriddle`````
use lower case to match other error messages
…nkov Apply `Recovery::Forbidden` when reparsing pasted macro fragments. Fixes rust-lang#137874. The changes to the output of `tests/ui/associated-consts/issue-93835.rs` partly undo the changes seen when `NtTy` was removed in rust-lang#133436, which is good. r? ``@petrochenkov``
make `Arguments::as_statically_known_str` doc(hidden) Fixes `as_statically_known_str` being [visible](https://doc.rust-lang.org/nightly/std/fmt/struct.Arguments.html#method.as_statically_known_str) ([Rendered](https://github.com/user-attachments/assets/45482d9f-2ec5-4610-be9c-b231bd2850c6)) This snuck in with rust-lang#138650, cc `@thaliaarchi` This is also visible in the beta docs. `@rustbot` label +beta-nominated
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bad13a9 (parent) -> 1e008dd (this PR) Test differencesShow 391 test diffsStage 0
Stage 1
Stage 2
(and 65 additional test diffs) Additionally, 226 doctest diffs were found. These are ignored, as they are noisy. Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: bad13a970a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 5, 2025
|
Finished benchmarking commit (1e008dd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -3.6%, secondary 8.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.1%, secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 777.657s -> 777.007s (-0.08%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
panic_bounds_checkin Unicode checks. #138024 (Allow optimizing outpanic_bounds_checkin Unicode checks.)associated_items. #138826 (StableMIR: Addassociated_items.)Recovery::Forbiddenwhen reparsing pasted macro fragments. #139341 (ApplyRecovery::Forbiddenwhen reparsing pasted macro fragments.)Arguments::as_statically_known_strdoc(hidden) #139389 (makeArguments::as_statically_known_strdoc(hidden))r? @ghost
@rustbot modify labels: rollup
Create a similar rollup