Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options #139647

eholk · 2025-04-10T19:19:20Z

This is a tiny step towards implementing the rustc side of support for implementing packages as optional namespaces (#122349). We add support for parsing command line options like --extern foo::bar=libbar.rlib when the -Z namespaced-crates option is present.

We don't do anything further with them. The next step is to plumb this down to the name resolver.

This PR also generally refactors the extern argument parsing code and adds some unit tests to make it clear what forms should be accepted with and without the flag.

cc @epage @ehuss

rustbot · 2025-04-10T19:19:25Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

epage · 2025-04-10T19:25:01Z

compiler/rustc_session/src/config/externs.rs

Did you mean to add this file in the previous commit?

Oh, I did. I forgot to git add :(

eholk · 2025-04-10T21:54:59Z

Setting this as a draft since @b-naber has a branch that's almost ready to turn into a PR and has significant overlap with this one.

@rustbot author

rustbot · 2025-04-10T21:55:03Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

eholk · 2025-04-14T19:29:25Z

I synced with @b-naber. This change doesn't really overlap with the changes in their branch, but would be useful to their branch, so I think it makes sense to go ahead and merge this.

@rustbot ready

fmease · 2025-04-15T10:48:30Z

Thanks! Looks fine as a starting off point for this feature. I'll give you a chance to fix your git history (by either squashing or making the first commit able to stand on its own) then r=me

@bors rollup (refacting+unstable)

compiler/rustc_session/src/options.rs

Also refactors some of the crate name parsing code and adds unit tests Issue rust-lang#122349 Co-authored-by: León Orell Valerian Liehr <[email protected]>

eholk · 2025-04-15T20:06:11Z

Thanks for the review. I squashed everything together.

@bors r=fmease

bors · 2025-04-15T20:06:13Z

📌 Commit 1670c40 has been approved by fmease

It is now in the queue for this repository.

eholk · 2025-04-15T20:07:11Z

@bors r-

eholk · 2025-04-15T20:07:45Z

(Oops, my git push hadn't finished before I did that. I'll try again once git push finishes.)

eholk · 2025-04-15T20:15:03Z

@bors r=fmease

bors · 2025-04-15T20:15:06Z

📌 Commit f35c85f has been approved by fmease

It is now in the queue for this repository.

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options This is a tiny step towards implementing the rustc side of support for implementing packages as optional namespaces (rust-lang#122349). We add support for parsing command line options like `--extern foo::bar=libbar.rlib` when the `-Z namespaced-crates` option is present. We don't do anything further with them. The next step is to plumb this down to the name resolver. This PR also generally refactors the extern argument parsing code and adds some unit tests to make it clear what forms should be accepted with and without the flag. cc `@epage` `@ehuss`

Rollup of 8 pull requests Successful merges: - rust-lang#136926 (Stabilize `-Zdwarf-version` as `-Cdwarf-version`) - rust-lang#139647 (Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139867 (Fix some tidy paper cuts) - rust-lang#139871 (Fix wrong "move keyword" suggestion for async gen block) - rust-lang#139880 (Don't compute name of associated item if it's an RPITIT) - rust-lang#139884 (Update books) - rust-lang#139886 (`borrowck_graphviz_*` attribute tweaks) r? `@ghost` `@rustbot` modify labels: rollup

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options This is a tiny step towards implementing the rustc side of support for implementing packages as optional namespaces (rust-lang#122349). We add support for parsing command line options like `--extern foo::bar=libbar.rlib` when the `-Z namespaced-crates` option is present. We don't do anything further with them. The next step is to plumb this down to the name resolver. This PR also generally refactors the extern argument parsing code and adds some unit tests to make it clear what forms should be accepted with and without the flag. cc ``@epage`` ``@ehuss``

Rollup of 10 pull requests Successful merges: - rust-lang#139647 (Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options) - rust-lang#139823 (Fix some bootstrap papercuts) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139867 (Fix some tidy paper cuts) - rust-lang#139871 (Fix wrong "move keyword" suggestion for async gen block) - rust-lang#139876 (Make CodeStats' type_sizes public) - rust-lang#139880 (Don't compute name of associated item if it's an RPITIT) - rust-lang#139884 (Update books) - rust-lang#139886 (`borrowck_graphviz_*` attribute tweaks) - rust-lang#139893 (Add test for issue 125668) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#139647 (Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options) - rust-lang#139823 (Fix some bootstrap papercuts) - rust-lang#139867 (Fix some tidy paper cuts) - rust-lang#139871 (Fix wrong "move keyword" suggestion for async gen block) - rust-lang#139876 (Make CodeStats' type_sizes public) - rust-lang#139880 (Don't compute name of associated item if it's an RPITIT) - rust-lang#139884 (Update books) - rust-lang#139886 (`borrowck_graphviz_*` attribute tweaks) - rust-lang#139893 (Add test for issue 125668) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139647 - eholk:package-namespace, r=fmease Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options This is a tiny step towards implementing the rustc side of support for implementing packages as optional namespaces (rust-lang#122349). We add support for parsing command line options like `--extern foo::bar=libbar.rlib` when the `-Z namespaced-crates` option is present. We don't do anything further with them. The next step is to plumb this down to the name resolver. This PR also generally refactors the extern argument parsing code and adds some unit tests to make it clear what forms should be accepted with and without the flag. cc ```@epage``` ```@ehuss```

rustbot assigned SparrowLii Apr 10, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2025

epage reviewed Apr 10, 2025

View reviewed changes

eholk marked this pull request as draft April 10, 2025 21:54

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2025

eholk marked this pull request as ready for review April 14, 2025 19:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025

eholk force-pushed the package-namespace branch from 942ab5d to 4fcec5c Compare April 14, 2025 20:02

fmease assigned fmease and unassigned SparrowLii Apr 15, 2025

fmease approved these changes Apr 15, 2025

View reviewed changes

fmease reviewed Apr 15, 2025

View reviewed changes

compiler/rustc_session/src/options.rs Outdated Show resolved Hide resolved

petrochenkov self-assigned this Apr 15, 2025

Add unstable foo::bar extern command line arguments

f35c85f

Also refactors some of the crate name parsing code and adds unit tests Issue rust-lang#122349 Co-authored-by: León Orell Valerian Liehr <[email protected]>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2025

eholk force-pushed the package-namespace branch from 1670c40 to f35c85f Compare April 15, 2025 20:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2025

petrochenkov removed their assignment Apr 15, 2025

Zalathar mentioned this pull request Apr 16, 2025

Rollup of 8 pull requests #139888

Closed

Zalathar mentioned this pull request Apr 16, 2025

Rollup of 10 pull requests #139895

Closed

matthiaskrgr mentioned this pull request Apr 16, 2025

Rollup of 9 pull requests #139912

Merged

bors merged commit 723ef24 into rust-lang:master Apr 16, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options #139647

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options #139647

eholk commented Apr 10, 2025 •

edited by fmease

Loading

rustbot commented Apr 10, 2025

epage Apr 10, 2025

eholk Apr 10, 2025

eholk commented Apr 10, 2025

rustbot commented Apr 10, 2025

eholk commented Apr 14, 2025

fmease commented Apr 15, 2025 •

edited

Loading

eholk commented Apr 15, 2025

bors commented Apr 15, 2025

eholk commented Apr 15, 2025

eholk commented Apr 15, 2025

eholk commented Apr 15, 2025

bors commented Apr 15, 2025

Add unstable parsing of --extern foo::bar=libbar.rlib command line options #139647

Add unstable parsing of --extern foo::bar=libbar.rlib command line options #139647

Conversation

eholk commented Apr 10, 2025 • edited by fmease Loading

rustbot commented Apr 10, 2025

epage Apr 10, 2025

Choose a reason for hiding this comment

eholk Apr 10, 2025

Choose a reason for hiding this comment

eholk commented Apr 10, 2025

rustbot commented Apr 10, 2025

eholk commented Apr 14, 2025

fmease commented Apr 15, 2025 • edited Loading

eholk commented Apr 15, 2025

bors commented Apr 15, 2025

eholk commented Apr 15, 2025

eholk commented Apr 15, 2025

eholk commented Apr 15, 2025

bors commented Apr 15, 2025

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options #139647

Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options #139647

eholk commented Apr 10, 2025 •

edited by fmease

Loading

fmease commented Apr 15, 2025 •

edited

Loading