Normalize ADT field in find_tails_for_unsizing
#139818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR changes a file inside |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 15, 2025
…=oli-obk Normalize ADT field in `find_tails_for_unsizing` See the comment inline and in the test. TL;DR is that we're getting getting a type from a `type_of` query and then matching on it structurally in codegen, so we're obligated to normalize it. The fact that this wasn't triggered earlier is that all of the types that have `CoerceUnsized` implementations never encounter aliases when peeling the ADT down to their base reference/ptr type. **NOTE**: I also renamed some things and reorganized the function a bit. Fixes rust-lang#139812 Fixes rust-lang#74451, which I didn't think was interesting enough to add another test. r? oli-obk
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#138906 (Reject test executables when not supported by target) - rust-lang#139818 (Normalize ADT field in `find_tails_for_unsizing`) - rust-lang#139819 (Use `rust-cache` to speed-up `citool` compilation) - rust-lang#139824 (Remove safe remove) - rust-lang#139859 (CI: rename MacOS runner) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138455 (`librustdoc`: more `impl fmt::Display`) - rust-lang#139818 (Normalize ADT field in `find_tails_for_unsizing`) - rust-lang#139819 (Use `rust-cache` to speed-up `citool` compilation) - rust-lang#139824 (Remove safe remove) - rust-lang#139848 ( Reduce kw::Empty usage, part 5) - rust-lang#139859 (CI: rename MacOS runner) - rust-lang#139877 (Add warning comment to `Take::get_ref` and `Chain::get_ref`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
Rollup merge of rust-lang#139818 - compiler-errors:normalize-tails, r=oli-obk Normalize ADT field in `find_tails_for_unsizing` See the comment inline and in the test. TL;DR is that we're getting getting a type from a `type_of` query and then matching on it structurally in codegen, so we're obligated to normalize it. The fact that this wasn't triggered earlier is that all of the types that have `CoerceUnsized` implementations never encounter aliases when peeling the ADT down to their base reference/ptr type. **NOTE**: I also renamed some things and reorganized the function a bit. Fixes rust-lang#139812 Fixes rust-lang#74451, which I didn't think was interesting enough to add another test. r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment inline and in the test.
TL;DR is that we're getting getting a type from a
type_ofquery and then matching on it structurally in codegen, so we're obligated to normalize it. The fact that this wasn't triggered earlier is that all of the types that haveCoerceUnsizedimplementations never encounter aliases when peeling the ADT down to their base reference/ptr type.NOTE: I also renamed some things and reorganized the function a bit.
Fixes #139812
Fixes #74451, which I didn't think was interesting enough to add another test.
r? oli-obk