Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed there are four spots in
Box
's documentation where the safety notes are incomplete. According to Rust's stacked borrows rules, when APIs likefrom_raw
take ownership of a pointer's memory, that original pointer shouldn't be touched anymore. Other similar APIs make this clear, like Vec::from_raw_parts specifically says:But Box's docs are currently missing this important warning.