Revert "Various codegen_llvm cleanups#138674" #139874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
petrochenkov
added
the
beta-nominated
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
|
Closing in favor of #139878. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2025
…er-errors Revert "Deduplicate template parameter creation" This reverts commit 6adc2c1. More precise subset of rust-lang#139874.
apiraino
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caused some regressions on CI, but in practice the regressions can be much larger - #t-compiler > Large slowdown in compiler build @ 💬 so revert it entirely for now.