Skip to content

run-make: drop os_pipe workaround now that anonymous_pipe is stable on beta #139976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

jieyouxu
Copy link
Member

Follow-up to #137537 where I had to include a temporary dep on os_pipe before anonymous_pipe was stabilized. Now that anonymous_pipe is stable on beta, we can get rid of this workaround.

Closes #137532. (Final cleanup item)

r? @Kobzol

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 17, 2025

Nice!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 17, 2025

📌 Commit 83af9f5 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#137881 (Add `copy_within` to `IndexSlice`)
 - rust-lang#138599 (avoid overflow when generating debuginfo for expanding recursive types)
 - rust-lang#139934 (Update `compiler-builtins` to 0.1.155)
 - rust-lang#139976 (run-make: drop `os_pipe` workaround now that `anonymous_pipe` is stable on beta)
 - rust-lang#139989 (tests: adjust 101082 test for LLVM 21 fix)
 - rust-lang#139991 (remove stray file)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#137881 (Add `copy_within` to `IndexSlice`)
 - rust-lang#138599 (avoid overflow when generating debuginfo for expanding recursive types)
 - rust-lang#139934 (Update `compiler-builtins` to 0.1.155)
 - rust-lang#139976 (run-make: drop `os_pipe` workaround now that `anonymous_pipe` is stable on beta)
 - rust-lang#139989 (tests: adjust 101082 test for LLVM 21 fix)
 - rust-lang#139991 (remove stray file)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 095486e into rust-lang:master Apr 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2025
Rollup merge of rust-lang#139976 - jieyouxu:plumbing, r=Kobzol

run-make: drop `os_pipe` workaround now that `anonymous_pipe` is stable on beta

Follow-up to rust-lang#137537 where I had to include a temporary dep on `os_pipe` before `anonymous_pipe` was stabilized. Now that `anonymous_pipe` is stable on beta, we can get rid of this workaround.

Closes rust-lang#137532. (Final cleanup item)

r? `@Kobzol`
@jieyouxu jieyouxu deleted the plumbing branch April 19, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent run-make test recipes (rmake.rs) from using *any* unstable features
4 participants