-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove avx512dq
and avx512vl
implication for avx512fp16
#140002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sayantn
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
sayantn:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
The job Click to see the possible cause of the failure (guessed by this bot)
|
So, this requires a fair amount of fixes in stdarch. I will send the PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-SIMD
Area: SIMD (Single Instruction Multiple Data)
A-target-feature
Area: Enabling/disabling target features like AVX, Neon, etc.
O-x86_32
Target: x86 processors, 32 bit (like i686-*) (IA-32)
O-x86_64
Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Intel,
avx512fp16
requires onlyavx512bw
, but LLVM also enablesavx512vl
andavx512dq
whenavx512fp16
is active. This is relic code, and will be fixed in LLVM soon. We should remove this from Rust too asap, especially before the stabilization of AVX512Related:
fma
andf16c
foravx512f
instd_detect
stdarch#1781@rustbot label O-x86_64 O-x86_32 A-SIMD A-target-feature T-compiler
r? @Amanieu