Skip to content

Remove (now unused) #[rustc_macro_edition_2021] attribute #140067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 20, 2025

Now that #139114 has been merged, we no longer need the temporary hack (#[rustc_macro_edition_2021]) that we introduced in #138717. Time to remove it.

It was only temporarily used by pin!(), which no longer needs it.
@m-ou-se m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2025
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

@Urgau
Copy link
Member

Urgau commented Apr 20, 2025

r? Urgau
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 20, 2025

📌 Commit 5f4d676 has been approved by Urgau

It is now in the queue for this repository.

@rustbot rustbot assigned Urgau and unassigned petrochenkov Apr 20, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 20, 2025
…Urgau

Remove (now unused) #[rustc_macro_edition_2021] attribute

Now that rust-lang#139114 has been merged, we no longer need the temporary hack (`#[rustc_macro_edition_2021]`) that we introduced in rust-lang#138717. Time to remove it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 5 pull requests

Successful merges:

 - rust-lang#138870 (Add target-specific NaN payloads for the missing tier 2 targets)
 - rust-lang#139309 (make abi_unsupported_vector_types a hard error)
 - rust-lang#140063 (Remove stray newline from post-merge report)
 - rust-lang#140067 (Remove (now unused) #[rustc_macro_edition_2021] attribute)
 - rust-lang#140068 (replace broken links armv7-rtems-eabihf.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@m-ou-se m-ou-se mentioned this pull request Apr 20, 2025
29 tasks
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 5 pull requests

Successful merges:

 - rust-lang#138870 (Add target-specific NaN payloads for the missing tier 2 targets)
 - rust-lang#139028 (Make target maintainers more easily pingable)
 - rust-lang#140063 (Remove stray newline from post-merge report)
 - rust-lang#140067 (Remove (now unused) #[rustc_macro_edition_2021] attribute)
 - rust-lang#140068 (replace broken links armv7-rtems-eabihf.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 44cbe82 into rust-lang:master Apr 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
Rollup merge of rust-lang#140067 - m-ou-se:remove-macro-2021-hack, r=Urgau

Remove (now unused) #[rustc_macro_edition_2021] attribute

Now that rust-lang#139114 has been merged, we no longer need the temporary hack (`#[rustc_macro_edition_2021]`) that we introduced in rust-lang#138717. Time to remove it.
@m-ou-se m-ou-se deleted the remove-macro-2021-hack branch April 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants