Rollup of 5 pull requests #140079

ChrisDenton · 2025-04-20T13:02:51Z

Successful merges:

simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors #137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors)
transmutability: remove NFA intermediate representation #139990 (transmutability: remove NFA intermediate representation)
rustc-dev-guide subtree update #140044 (rustc-dev-guide subtree update)
Switch exploit mitigations to mdbook footnotes #140051 (Switch exploit mitigations to mdbook footnotes)
docs: fix typo change from inconstants to invariants #140054 (docs: fix typo change from inconstants to invariants)

r? @ghost
@rustbot modify labels: rollup

Fix link to rustc_* TEST attributes in ui.md

1. added two new parts: Bootstrapping and Supporting Infrastructure; 2. touched up names of pre-existing parts, to match actual names in sidebar; 3. syntactic nits (start description of Analysis with a capital letter); and 4. make numbered list use only 1. Co-authored-by: Tshepang Mbambo <[email protected]>

Update table of contents in about-this-guide.md

Update "crater" link to actually point to crater.md

ease copy-paste

Not obvious what "sort by" means

"how much to trust" implies the opposite

add missing word

date-check rdg contribution section

fix path

Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot.toml

- use correct code block markers - add missing title - rustfmt can now use edition setting in its config ... and this is set in Rust repo - reduce visual noise - needless repetition - convention is to start sentence with upper case - sembr - whitespace - semi-heading not adding much value - fix grammar

…aning Coding conventions chapter cleaning

Signed-off-by: xizheyin <[email protected]>

Remind to update dev branch while behind too many commits

bors · 2025-04-20T13:58:36Z

⌛ Testing commit d3fab38 with merge c51ea43...

…enton Rollup of 5 pull requests Successful merges: - rust-lang#137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors) - rust-lang#139990 (transmutability: remove NFA intermediate representation) - rust-lang#140044 (rustc-dev-guide subtree update) - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes) - rust-lang#140054 (docs: fix typo change from inconstants to invariants) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-20T15:38:23Z

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test result: FAILED. 332 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 15.43s

Some tests failed in compiletest suite=mir-opt mode=mir-opt host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc
Build completed unsuccessfully in 1:32:48
make: *** [Makefile:113: ci-msvc-py] Error 1
  local time: Sun Apr 20 15:38:05 CUT 2025
  network time: Sun, 20 Apr 2025 15:38:05 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-04-20T15:39:01Z

💔 Test failed - checks-actions

ChrisDenton · 2025-04-20T15:39:23Z

@bors retry failed to remove and recreate output directory

bors · 2025-04-20T18:51:45Z

⌛ Testing commit d3fab38 with merge d371765...

…enton Rollup of 5 pull requests Successful merges: - rust-lang#137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors) - rust-lang#139990 (transmutability: remove NFA intermediate representation) - rust-lang#140044 (rustc-dev-guide subtree update) - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes) - rust-lang#140054 (docs: fix typo change from inconstants to invariants) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-20T20:07:00Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] core::build_steps::doc::Standalone { compiler: Compiler { stage: 2, host: x86_64-apple-darwin, forced_compiler: false }, target: aarch64-apple-ios-macabi } -- 0.868
##[group]Documenting stage2 standalone (x86_64-apple-darwin -> x86_64-apple-ios-macabi)
##[endgroup]
[TIMING] core::build_steps::doc::Standalone { compiler: Compiler { stage: 2, host: x86_64-apple-darwin, forced_compiler: false }, target: x86_64-apple-ios-macabi } -- 0.843
dyld[13143]: Library not loaded: @rpath/librustc_driver-083a5cd6fc07d78e.dylib
  Referenced from: <EAC1AEE6-64D1-36E1-BE2B-F85C14E4CF3A> /Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage1-rustc/x86_64-apple-darwin/release/rustc-main
  Reason: tried: '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage1-rustc/x86_64-apple-darwin/release/../lib/librustc_driver-083a5cd6fc07d78e.dylib' (no such file), '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage1-rustc/x86_64-apple-darwin/release/../lib/librustc_driver-083a5cd6fc07d78e.dylib' (no such file)
Command "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc" "--target" "aarch64-apple-ios" "--print=deployment-target" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 1:08:12
  local time: Sun Apr 20 20:06:47 UTC 2025
  network time: Sun, 20 Apr 2025 20:06:47 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2025-04-20T20:07:36Z

💔 Test failed - checks-actions

ChrisDenton · 2025-04-20T21:24:24Z

I could be wrong but that looks spurious to me. None of the PRs should cause librustc_driver not to be found when documenting stage 2. Let's try again

@bors retry Library not loaded: @rpath/librustc_driver-083a5cd6fc07d78e.dylib

bors · 2025-04-20T22:41:31Z

⌛ Testing commit d3fab38 with merge b8005bf...

bors · 2025-04-21T01:43:39Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing b8005bf to master...

rust-timer · 2025-04-21T01:45:06Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#137953	simd intrinsics with mask: accept unsigned integer masks, a…	`280b3262927fcf4497f838dd2a21a2cabe3fa6a9` (link)
#139990	transmutability: remove NFA intermediate representation	`e0667153950941ec3514418503e94ada2bd00b99` (link)
#140044	rustc-dev-guide subtree update	`b7ffa50370ca6f1995cb54718afb4f51fc3426db` (link)
#140051	Switch exploit mitigations to mdbook footnotes	`c752cb76d683d901faa81526aee0391e329485c3` (link)
#140054	docs: fix typo change from inconstants to invariants	`6fb077e1db1ba238bb9532b499e69556d00bd53b` (link)

previous master: b8c54d6358

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-04-21T01:46:00Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b8c54d6 (parent) -> b8005bf (this PR)

Test differences

Show 67 test diffs

Stage 1

errors::verify_codegen_ssa_aix_strip_not_used_137: [missing] -> pass (J0)
errors::verify_codegen_ssa_aix_strip_not_used_139: pass -> [missing] (J0)
errors::verify_codegen_ssa_compiler_builtins_cannot_call_135: [missing] -> pass (J0)
errors::verify_codegen_ssa_compiler_builtins_cannot_call_137: pass -> [missing] (J0)
errors::verify_codegen_ssa_dlltool_fail_import_library_131: [missing] -> pass (J0)
errors::verify_codegen_ssa_dlltool_fail_import_library_133: pass -> [missing] (J0)
errors::verify_codegen_ssa_error_calling_dlltool_133: [missing] -> pass (J0)
errors::verify_codegen_ssa_error_calling_dlltool_135: pass -> [missing] (J0)
errors::verify_codegen_ssa_error_creating_import_library_136: [missing] -> pass (J0)
errors::verify_codegen_ssa_error_creating_import_library_138: pass -> [missing] (J0)
errors::verify_codegen_ssa_error_creating_remark_dir_134: [missing] -> pass (J0)
errors::verify_codegen_ssa_error_creating_remark_dir_136: pass -> [missing] (J0)
errors::verify_codegen_ssa_error_writing_def_file_132: [missing] -> pass (J0)
errors::verify_codegen_ssa_error_writing_def_file_134: pass -> [missing] (J0)
errors::verify_codegen_ssa_failed_to_get_layout_130: [missing] -> pass (J0)
errors::verify_codegen_ssa_failed_to_get_layout_132: pass -> [missing] (J0)
errors::verify_codegen_ssa_forbidden_target_feature_attr_129: [missing] -> pass (J0)
errors::verify_codegen_ssa_forbidden_target_feature_attr_131: pass -> [missing] (J0)
errors::verify_codegen_ssa_illegal_link_ordinal_format_127: [missing] -> pass (J0)
errors::verify_codegen_ssa_illegal_link_ordinal_format_129: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_link_ordinal_nargs_126: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_link_ordinal_nargs_128: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_cannot_return_115: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_cannot_return_116: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_cast_wide_pointer_119: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_cast_wide_pointer_121: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_element_type_116: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_element_type_117: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_pointer_120: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_pointer_122: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_usize_121: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_usize_123: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_vector_element_type_124: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_expected_vector_element_type_126: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_mask_type_114: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_mask_wrong_element_type_114: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_third_arg_element_type_118: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_cast_122: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_cast_124: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_operation_123: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_operation_125: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_symbol_118: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_symbol_120: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_symbol_of_size_117: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_monomorphization_unsupported_symbol_of_size_119: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_monomorphization_vector_argument_115: pass -> [missing] (J0)
errors::verify_codegen_ssa_invalid_no_sanitize_125: [missing] -> pass (J0)
errors::verify_codegen_ssa_invalid_no_sanitize_127: pass -> [missing] (J0)
errors::verify_codegen_ssa_mixed_export_name_and_no_mangle_138: [missing] -> pass (J0)
errors::verify_codegen_ssa_mixed_export_name_and_no_mangle_140: pass -> [missing] (J0)
errors::verify_codegen_ssa_target_feature_safe_trait_128: [missing] -> pass (J0)
errors::verify_codegen_ssa_target_feature_safe_trait_130: pass -> [missing] (J0)
errors::verify_codegen_ssa_xcrun_failed_invoking_139: [missing] -> pass (J0)
errors::verify_codegen_ssa_xcrun_failed_invoking_141: pass -> [missing] (J0)
errors::verify_codegen_ssa_xcrun_sdk_path_warning_141: [missing] -> pass (J0)
errors::verify_codegen_ssa_xcrun_sdk_path_warning_143: pass -> [missing] (J0)
errors::verify_codegen_ssa_xcrun_unsuccessful_140: [missing] -> pass (J0)
errors::verify_codegen_ssa_xcrun_unsuccessful_142: pass -> [missing] (J0)
maybe_transmutable::tests::union::union: [missing] -> pass (J0)
[ui] tests/ui/simd/intrinsic/generic-gather-pass.rs: pass -> [missing] (J1)
[ui] tests/ui/simd/intrinsic/generic-gather-scatter-pass.rs: [missing] -> pass (J1)
[ui] tests/ui/simd/intrinsic/generic-gather-scatter.rs: [missing] -> pass (J1)
[ui] tests/ui/simd/intrinsic/generic-gather.rs: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/simd/intrinsic/generic-gather-pass.rs: pass -> [missing] (J2)
[ui] tests/ui/simd/intrinsic/generic-gather-scatter-pass.rs: [missing] -> pass (J2)
[ui] tests/ui/simd/intrinsic/generic-gather-scatter.rs: [missing] -> pass (J2)
[ui] tests/ui/simd/intrinsic/generic-gather.rs: pass -> [missing] (J2)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b8005bff3248cfc6e327faf4fa631ac49bb49ba9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 8397.2s -> 5922.1s (-29.5%)
x86_64-apple-2: 5816.9s -> 4927.2s (-15.3%)
dist-apple-various: 5936.4s -> 6583.1s (10.9%)
x86_64-mingw-1: 8641.4s -> 9415.3s (9.0%)
dist-x86_64-apple: 9449.9s -> 8767.9s (-7.2%)
dist-various-2: 3172.6s -> 3376.4s (6.4%)
dist-android: 2592.0s -> 2449.9s (-5.5%)
dist-powerpc-linux: 5300.9s -> 5021.2s (-5.3%)
x86_64-gnu-debug: 5960.2s -> 6261.7s (5.1%)
x86_64-rust-for-linux: 2755.4s -> 2623.7s (-4.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-21T03:09:22Z

Finished benchmarking commit (b8005bf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.1%, secondary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 2.6%]	6
Regressions ❌ (secondary)	3.9%	[2.0%, 5.8%]	2
Improvements ✅ (primary)	-1.0%	[-1.8%, -0.6%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-1.8%, 2.6%]	10

Cycles

Results (primary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.8%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-0.5%, 0.8%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.102s -> 773.608s (-0.19%)
Artifact size: 365.03 MiB -> 365.05 MiB (0.01%)

smanilov and others added 30 commits April 11, 2025 12:12

Fix link to rustc_* TEST attributes in ui.md

c285fe7

Merge pull request rust-lang#2324 from smanilov/patch-3

5806cb5

Fix link to rustc_* TEST attributes in ui.md

Merge pull request rust-lang#2320 from smanilov/patch-1

e6eb98f

Update table of contents in about-this-guide.md

Update "crater" link to actually point to crater.md

c5e2369

Merge pull request rust-lang#2325 from freyacodes/crater-link-fix

46df457

Update "crater" link to actually point to crater.md

ease copy-paste

e0a2250

Merge pull request rust-lang#2326 from rust-lang/tshepang-patch-3

1a20e21

ease copy-paste

use more simple language

3ae1c9d

Not obvious what "sort by" means

remove implied text

770a6fc

"how much to trust" implies the opposite

add missing word

7ba53b7

Merge pull request rust-lang#2328 from rust-lang/tshepang-patch-3

af4419a

Merge pull request rust-lang#2329 from rust-lang/tshepang-patch-4

208e421

add missing word

Merge pull request rust-lang#2327 from rust-lang/tshepang-patch-1

14ea903

date-check rdg contribution section

e33a6d6

Merge pull request rust-lang#2330 from rust-lang/tshepang-patch-5

f79a89d

date-check rdg contribution section

fix path

667aa2e

Merge pull request rust-lang#2331 from rust-lang/tshepang-patch-6

17f72ff

fix path

use consistent title capitalization

2af7ec3

Enable [canonicalize-issue-links] and [no-mentions] in triagebot.toml

40bfc14

Merge pull request rust-lang#2335 from Urgau/triagebot-feat-1

de1dfd3

Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot.toml

tests: document -A {unused,internal_features} ui test mode presets

8c378f7

Merge pull request rust-lang#2321 from jieyouxu/ui-lint-allows

38f06e3

Merge pull request rust-lang#2334 from rust-lang/consistency

b3b89b6

Merge pull request rust-lang#2333 from rust-lang/convetions-chapt-cle…

97be6a6

…aning Coding conventions chapter cleaning

Remind to update dev branch while behind too many commits

855ecf9

Signed-off-by: xizheyin <[email protected]>

Merge pull request rust-lang#2337 from xizheyin/sync-code

a9bcdb0

Remind to update dev branch while behind too many commits

add a first version of autodiff docs

1236dcb

Merge pull request rust-lang#2339 from rust-lang/autodiff-docs

35a3c3b

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Apr 20, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2025

bors merged commit b8005bf into rust-lang:master Apr 21, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 21, 2025

This was referenced Apr 21, 2025

Stop projecting into SIMD types in ui/simd/ tests #138036

Open

transmutability: Short-circuit NFA->DFA #139937

Closed

ChrisDenton deleted the rollup-2h5cg94 branch April 21, 2025 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #140079

Rollup of 5 pull requests #140079

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

rust-log-analyzer commented Apr 20, 2025

bors commented Apr 20, 2025

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

rust-log-analyzer commented Apr 20, 2025

bors commented Apr 20, 2025

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

bors commented Apr 21, 2025

rust-timer commented Apr 21, 2025

github-actions bot commented Apr 21, 2025

Stage 1

Stage 2

rust-timer commented Apr 21, 2025

Rollup of 5 pull requests #140079

Rollup of 5 pull requests #140079

Conversation

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

rust-log-analyzer commented Apr 20, 2025

bors commented Apr 20, 2025

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

rust-log-analyzer commented Apr 20, 2025

bors commented Apr 20, 2025

ChrisDenton commented Apr 20, 2025

bors commented Apr 20, 2025

bors commented Apr 21, 2025

rust-timer commented Apr 21, 2025

github-actions bot commented Apr 21, 2025

Test differences

Stage 1

Stage 2

Job duration changes

rust-timer commented Apr 21, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size