-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Unify sidebar buttons to use the same image #140135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
Is there a particular reason for using the hamburger icon in desktop mode, instead of In any case, this is my only question, and it's not that big of a deal. We finally have empirical feedback to work with here, and that trumps any amount of theorizing. @rfcbot fcp merge |
This comment was marked as off-topic.
This comment was marked as off-topic.
@rfcbot fcp cancel Uuuugggghhhh... why do I always forget to check the list of T- tags before calling fcp on a gui test like this? |
@notriddle proposal cancelled. |
@rfcbot fcp merge |
Team member @notriddle has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
@rfcbot concern hamburger-button-on-desktop |
Part of #139832.
The source sidebar looks like this with the new image:
r? @notriddle