Move sys::pal::os::Env into sys::env
#140143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although `Env` (as `Vars`), `Args`, path functions, and OS constants are publicly exposed via `std::env`, their implementations are each self-contained. Keep them separate in `std::sys` and make a new module, `sys::env`, for `Env`.
These have grown out of sync with the platforms.
rustbot
added
O-hermit
24 tasks
Also, update the same pattern of reuse in `sys::args` to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
Env(asVars),Args, path functions, and OS constants are publicly exposed viastd::env, their implementations are each self-contained. Keep them separate instd::sysand make a new module,sys::env, forEnv.Also fix
unsafe_op_in_unsafe_fnfor Unix and update the!DynSendand!DynSyncimpls which had grown out of sync with the platforms (see #48005 for discussion on that).r? joboet
Tracked in #117276.