Skip to content

test_nan: ensure the NAN contant is quiet #140149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test_nan: ensure the NAN contant is quiet #140149

wants to merge 2 commits into from
+20 −0

Conversation

RalfJung
Copy link
Member

Follow-up to #139483

r? @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 22, 2025
@tgross35
Copy link
Contributor

Thanks for updating the docs too, those constants are somewhat underdocumented. It would be nice if we eventually did something like #88734.

Cc @martn3, this may need some followup for mips since I think the NaN bit may be reversed in some circumstances.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 22, 2025

📌 Commit 5717623 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2025
@RalfJung
Copy link
Member Author

Cc @martn3, this may need some followup for mips since I think the NaN bit may be reversed in some circumstances.

The NAN is generated by const-eval which always assumes that the quiet/signaling bit being 1 means "quiet". So the test should pass on MIPS as well.

Rust doesn't really support targets where the quiet/signaling bit is reversed, and will show some odd behavior on those targets. The same goes for LLVM, so chances are good we're even unsound on those targets.

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 22, 2025
@ChrisDenton
Rollup merge of rust-lang#140149 - RalfJung:test_nan, r=tgross35
6864ec4 
test_nan: ensure the NAN contant is quiet

Follow-up to rust-lang#139483

r? `@tgross35`
@ChrisDenton ChrisDenton mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @tgross35 @bors @rustbot