Mark safe_suggestion and pushpop_unsafe as removed in feature_gate.rs #39071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
20 tasks
est31
changed the title
|
📌 Commit fd74177 has been approved by |
|
@est31 as per the comment in |
|
@durka better now? |
est31
force-pushed
the
master
branch
2 times, most recently
from
8bc812d to
f1a78c8
Compare
est31
changed the title
|
Since safe_suggestion never really existed, I'm not sure it's useful to put in the removed list as well... |
This removes the safe_suggestion feature from feature_gate.rs. It was added in commit 164f010 and then removed again in commit c11fe55 . As the removal was in the same PR rust-lang#38099 as the addition, we don't move it to the "removed" section. Removes an element from the whitelist of non gate tested unstable lang features (issue rust-lang#39059).
This marks the pushpop_unsafe feature as removed inside the feature_gate. It was added in commit 1829fa5 and then removed again in commit d399098 . Seems that the second commit forgot to mark it as removed in feature_gate.rs. This enables us to remove another element from the whitelist of non gate tested unstable lang features (issue rust-lang#39059).
durka
approved these changes
Jan 15, 2017
|
Thanks! @bors: r+ |
|
📌 Commit 7821ea8 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2017
Mark safe_suggestion and pushpop_unsafe as removed in feature_gate.rs This removes two features from feature_gate.rs: `safe_suggestion` and `pushpop_unsafe`. Both had been removed in other places already, but were forgotten to be removed from feature_gate.rs. * `safe_suggestion` was added in commit 164f010 and then removed again in commit c11fe55 both in the same PR #38099. * `pushpop_unsafe` was added in commit 1829fa5 and removed again in commit d399098 Removes two elements from the whitelist of non gate tested unstable lang features (issue #39059).
|
💔 Test failed - status-appveyor |
|
@bors: retry After nearly 5 hours it looks like AppVeyor lost track of those builds? I canceled manually to keep the queue moving. |
|
@alexcrichton it was likely this issue: http://status.appveyor.com/incidents/k06ydx9hkhbt |
bors
added a commit
that referenced
this pull request
Jan 16, 2017
Mark safe_suggestion and pushpop_unsafe as removed in feature_gate.rs This removes two features from feature_gate.rs: `safe_suggestion` and `pushpop_unsafe`. Both had been removed in other places already, but were forgotten to be removed from feature_gate.rs. * `safe_suggestion` was added in commit 164f010 and then removed again in commit c11fe55 both in the same PR #38099. * `pushpop_unsafe` was added in commit 1829fa5 and removed again in commit d399098 Removes two elements from the whitelist of non gate tested unstable lang features (issue #39059).
|
☀️ Test successful - status-appveyor, status-travis |
Merged
|
@est31 thanks for the pointer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two features from feature_gate.rs:
safe_suggestionandpushpop_unsafe. Both had been removed in other places already, but were forgotten to be removed from feature_gate.rs.safe_suggestionwas added in commit 164f010 and then removed again in commit c11fe55 both in the same PR Cast suggestions #38099.pushpop_unsafewas added in commit 1829fa5 and removed again in commit d399098Removes two elements from the whitelist of non gate tested unstable lang features (issue #39059).