-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use try{}
in try_fold
to decouple iterators in the library from Try
details
#77877
Use try{}
in try_fold
to decouple iterators in the library from Try
details
#77877
Conversation
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
They failed to parse in rustfmt on me in rust-lang/rust#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
To pick up rust-lang/rustfmt#4461 So that rustfmt has the parsing fix from rust-lang#76274 ...and do a reformat that it wants.
@bors try |
Awaiting bors try build completion |
⌛ Trying commit 8374c17 with merge 2c067c5235e779cd75e9f0cdfe572c64f1a12b9b... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 2c067c5235e779cd75e9f0cdfe572c64f1a12b9b with parent d65c08e, future comparison URL. |
They failed to parse in rustfmt on me in rust-lang/rust#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
Finished benchmarking try commit (2c067c5235e779cd75e9f0cdfe572c64f1a12b9b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Perf results look essentially unchanged to me, as expected. |
@bors r+ rollup |
📌 Commit 8374c17 has been approved by |
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#77877 (Use `try{}` in `try_fold` to decouple iterators in the library from `Try` details) - rust-lang#78089 (Fix issue with specifying generic arguments for primitive types) - rust-lang#78099 (Add missing punctuation) - rust-lang#78103 (Add link to rustdoc book in rustdoc help popup) Failed merges: r? `@ghost`
They failed to parse in rustfmt on me in rust-lang/rust#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
They failed to parse in rustfmt on me in rust-lang/rust#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
They failed to parse in rustfmt on me in rust-lang/rust#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
I'd like to experiment with changing the
?
/try
desugaring and correspondingly theTry
trait (see #42327 for discussions about the suboptimalities of the current one) and this change would keep from needing anycfg(bootstrap)
in iterator things.This will be lowered to the same thing, so shouldn't cause any perf issues:
rust/compiler/rustc_ast_lowering/src/expr.rs
Lines 428 to 429 in 08e2d46
But
I'll triggerI've triggered a perf run just in case.EDIT: changed to a draft because of the rustfmt-only syntax error. zulip thread about it: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn't.20support.20syntax.20from.20sept.3F/near/213098097EDIT: This now includes a rustfmt version bump to get through tidy.