Visit ForeignItems when marking dead code #79752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Dec 6, 2020
lcnr
approved these changes
Dec 6, 2020
lcnr
reviewed
Dec 6, 2020
lcnr
reviewed
Dec 6, 2020
|
please squash the commits r=me afterwards |
|
Squashed. |
|
Thanks 👍 @bors r+ rollup |
|
📌 Commit 37853f9 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Dec 9, 2020
Simplify visit_{foreign,trait}_item
Using an `if` seems like a better semantic fit and saves a few lines.
Noticed while looking at rust-lang#79752, but that's already merged.
r? `@lcnr,` cc `@cjgillot`
`@rustbot` modify labels +C-cleanup +T-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #79318
r? @lcnr