Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #95815

Merged
merged 1 commit into from
Apr 9, 2022
Merged

update Miri #95815

merged 1 commit into from
Apr 9, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 8, 2022

Fixes #95627
r? @ghost Cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2022

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Apr 8, 2022

📌 Commit 083be9c has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 8, 2022
@bors
Copy link
Contributor

bors commented Apr 8, 2022

⌛ Testing commit 083be9c with merge 705faf77dbc17acf78af73af51d613df6252a458...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (60/62)
.         (62/62)


/checkout/src/test/rustdoc-gui/search-filter.goml search-filter... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:42

@bors
Copy link
Contributor

bors commented Apr 8, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2022

@bors retry rustdoc-gui/search-filter.goml search-filter.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022
@bors
Copy link
Contributor

bors commented Apr 8, 2022

⌛ Testing commit 083be9c with merge 340f649...

@bors
Copy link
Contributor

bors commented Apr 9, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 340f649 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 9, 2022
@bors bors merged commit 340f649 into rust-lang:master Apr 9, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 9, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #95815!

Tested on commit 340f649.
Direct link to PR: #95815

🎉 miri on windows: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 9, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#95815!
44a68e4 
Tested on commit rust-lang/rust@340f649.
Direct link to PR: <rust-lang/rust#95815>

🎉 miri on windows: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
@RalfJung RalfJung deleted the miri branch April 9, 2022 02:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (340f649): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 0 1 0
mean2 N/A N/A N/A -0.3% N/A
max N/A N/A N/A -0.3% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#95624
6 participants
@RalfJung @bors @rust-log-analyzer @rust-highfive @rust-timer @rustbot