Skip to content

Add support for selecting workspace package #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 24, 2025

It can be useful for local benchmarking of workspace crates.

Extracted out of #2073.

It can be useful for local benchmarking of workspace crates.
@Kobzol Kobzol requested a review from nnethercote April 24, 2025 14:21
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but should something be added to one of the README.md files within collector/?

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 25, 2025

It isn't currently used for any of the benchmarks. I guess that the only current documentation are the doc comments on the BenchmarkConfig struct 🤷‍♂️

@nnethercote
Copy link
Contributor

Oh, https://github.com/rust-lang/rustc-perf/tree/master/collector/compile-benchmarks is the closest thing to docs we have on perf-config.json. It mentions a couple of fields and then just points at BenchmarkConfig, lol.

Ok, feel free to merge as is.

@Kobzol Kobzol merged commit 4521679 into rust-lang:master Apr 25, 2025
10 of 11 checks passed
@Kobzol Kobzol deleted the workspace-selection branch April 25, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants