Make auto-self-update setting work when no-self-update feature is enabled #3051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3040.
This patch series makes rustup work in the way that makes the most sense to me personally when built with self updates disabled. I've split four distinct, individually conservative changes I'd make into four patches. If you'd like me to drop or modify some of them, that's fine, of course. The first patch ("don't log on update if no-self-update is enabled but auto-self-update=disable") is the one that matters to me.
If you'd like docs or tests changes, I can do that, too, but no-self-update already doesn't seem to be covered by either. Enabling the feature causes the tests to fail even without these patches.