Give MathCell arithmetic ops implementations when MathCell is left value #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #969
Four functions are implemented for
ArrayView<MathCell, _>
in impl_methods.rs:zip_cell_with
,zip_cell_with_elem
,zip_cell_with_same_shape
,zip_cell_with_by_rows
.Operator overloading is implemented in impl_ops.rs for the following situations:
ArrayView<MathCell, _> binary_op &ArrayBase
ArrayView<MathCell, _> binary_op Scalar
ArrayView<MathCell, _> assign_op &ArrayBase
ArrayView<MathCell, _> assign_op Scalar
The unresolved problems are:
Currently
MathCell
can only be left value. The main reason are:(1) Conflicts occur when compiling
MathCell<A> op MathCell<B>
(2) Rust's orphan rules. We can't write code like this:
impl<T> Add<MathCell<T>> for T
. This will cause E0210 errorThe value in
MathCell
must beCopy
This is because the value in MathCell needs to be retrieved using the
get()
method. We cannot get&T
from&MathCell<T>
unless we create a new structureMathRefCell(RefCell<T>)