Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tuples for arrays #627

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

swfsql
Copy link

@swfsql swfsql commented May 1, 2019

Removes the features:

@bluss
Copy link
Member

bluss commented Aug 20, 2019

I'm skeptical of this change, but my vote doesn't necessarily matter.

Reasons:

  1. Less typing is better. Array::zeros(10) is good, no extra brackets needed. ((1, 2)) is less typing than ([1, 2]) because it is easy to repeat a keystroke
  2. It breaks about all code out there. As usual, try to deprecate a release before, if the change is to be done.

@bluss bluss marked this pull request as draft April 17, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[de-feature request] tuples for const-defined dimensions
3 participants