Update clarabel to v0.9.0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we decide to add support for wasm, then we need at least one test for the wasm build in our CI. Otherwise someone will break wasm compatibility later. for the clarabel version update: no problem |
|
I removed the WASM flag for now as I've discovered a bug when running Clarabel on WASM. It now only contains the version bump so hopefully we can merge this as is. |
|
@lovasoa could we get this merged? |
|
Thanks! |
|
@calintat do you remember what error you were experiencing when running wasm? |
|
Yes, I raised it on the Clarabel repo: oxfordcontrol/Clarabel.rs#125 It's not a WASM issue actually, it just means I can't switch to clarabel yet for my specific use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates clarabel to v0.9.0 which crucially includes a fix that makes it work on WASM.