Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers: Add AlignedBuffer #1600

Merged
merged 1 commit into from
Apr 5, 2025
Merged

helpers: Add AlignedBuffer #1600

merged 1 commit into from
Apr 5, 2025
+129 −0

Conversation

seijikun
Copy link
Contributor

@seijikun seijikun commented Apr 1, 2025

AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Copy link
Member

As mentioned in #1595 (comment), let's move to the mem module.

nicholasbishop
nicholasbishop reviewed Apr 1, 2025
View reviewed changes
@seijikun seijikun force-pushed the mr-alignedbuffer branch 2 times, most recently from 9263616 to bffd748 Compare April 1, 2025 22:37
phip1611
phip1611 requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your many contributions and your patience! I left a few remarks.

If you resolve them, we are good to go

@phip1611 phip1611 requested a review from nicholasbishop April 2, 2025 11:03
@seijikun seijikun force-pushed the mr-alignedbuffer branch 2 times, most recently from c37c461 to 812a105 Compare April 2, 2025 12:29
@seijikun seijikun requested a review from phip1611 April 2, 2025 12:34
@seijikun
Copy link
Contributor Author

seijikun commented Apr 5, 2025

Hm. The Lint failures seem to be outside the code I changed in this PR

@nicholasbishop
Copy link
Member

Probably due to 1.86 going stable recently. If you want to, please put up a separate pr with fixes for those lints. Or I can do it sometime this weekend probably.

@phip1611 phip1611 mentioned this pull request Apr 5, 2025
Merged
2 tasks
@phip1611
Copy link
Member

phip1611 commented Apr 5, 2025

I've set up #1602.

Thanks for your patience, @seijikun. We are almost there!

phip1611
phip1611 approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@seijikun @phip1611
mem: Add AlignedBuffer helper
efd5b59 
AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using
a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.
@phip1611 phip1611 enabled auto-merge April 5, 2025 21:17
@phip1611 phip1611 added this pull request to the merge queue Apr 5, 2025
Merged via the queue into rust-osdev:main with commit a0a76eb Apr 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

@nicholasbishop nicholasbishop Awaiting requested review from nicholasbishop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seijikun @nicholasbishop @phip1611