Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run iOS targets and other improvements #316

Merged
merged 6 commits into from
Oct 24, 2022
Merged

CI: Run iOS targets and other improvements #316

merged 6 commits into from
Oct 24, 2022

Conversation

josephlr
Copy link
Member

Fixes most of #194 (except being about to run on Apple Silicon).

This changes multiple things in the CI, so it might be easier to review commit by commit:

  • Move from actions-rs/toolchain to dtolnay/rust-toolchain
    • The current action we are using is unmantained: Project unmaintained actions-rs/toolchain#216
    • This replacement is faster, smaller, and more cachable.
    • We can also completely remove the toolchain step when testing with
      cross, as cross handles configuration of its own toolchain.
  • Make job names consistent. This makes it easier to tell on which targets we:
    • Build
    • Link
    • Run
  • Run iOS Simulator Tests
    • This builds, links, and runs the tests on x86_64-apple-ios using
      dinghy.
    • It moves the aarch64 targets which only Build/Link to their own job.
  • Update to actions/checkout@v3
  • Update to Swatinem/rust-cache@v2
  • Break up Tier 3 builds into a job for each build.
    • Makes things more parallel

The current action we are using is unmantained:
actions-rs/toolchain#216

This replacement is faster, smaller, and more cachable.

We can also completely remove the toolchain step when testing with
cross, as cross handles configuration of its own toolchain.

Signed-off-by: Joe Richey <[email protected]>
This makes it easier to tell on which targets we:
  - Build
  - Link
  - Run

Signed-off-by: Joe Richey <[email protected]>
This builds, links, and runs the tests on `x86_64-apple-ios` using
[`dinghy`](https://github.com/sonos/dinghy). It moves the targets
which only Build/Link to their own job.

Signed-off-by: Joe Richey <[email protected]>
Also move the cache step to be right before we start running cargo
commands.

Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr requested a review from newpavlov October 24, 2022 09:03
@josephlr josephlr mentioned this pull request Oct 24, 2022
6 tasks
@josephlr josephlr merged commit 2aabb63 into master Oct 24, 2022
@josephlr josephlr deleted the ci branch October 24, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants