Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[inline] attribute to the inner functions #596

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Add #[inline] attribute to the inner functions #596

merged 6 commits into from
Feb 1, 2025

Conversation

newpavlov
Copy link
Member

Closes #592

@newpavlov newpavlov requested a review from josephlr January 29, 2025 23:25
josephlr
josephlr requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid increasing compile times for users, we should probably only mark implementations as #[inline] if they really are just thin wrappers around a system function.

src/backends/linux_android_with_fallback.rs Show resolved Hide resolved
src/backends/netbsd.rs Show resolved Hide resolved
src/backends/wasm_js.rs Outdated Show resolved Hide resolved
@newpavlov newpavlov requested a review from josephlr January 31, 2025 10:58
josephlr
josephlr approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/backends/use_file.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the cold function in this file need similar treatment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, yes.

@newpavlov newpavlov merged commit ce3b017 into master Feb 1, 2025
58 checks passed
@newpavlov newpavlov deleted the inline_attr branch February 1, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infallible nature of windows 10 RNG isn't propagated to user during runtime
2 participants
@newpavlov @josephlr