feat!: function can take owned 'AsRef<Path>' instead of borrow #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AsRef<U>` is implemented for any `&T` when `T` does implement `AsRef<U>` too.
Therefore, we can leave to the caller the decision to give an owned value or
a borrowed value, as long as the type implements `AsRef<Path>`, the borrowed
type will too.
I feel that it's more natural, since you can then give a `String`, a `&str`,
which avoids things like `read(&"my_file.txt")` instead of `read("my_file.txt")`.
What do you think?
antoine-de
approved these changes
Oct 8, 2024
Tristramg
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsRef<U>is implemented for any&TwhenTdoes implementAsRef<U>too. Therefore, we can leave to the caller the decision to give an owned value or a borrowed value, as long as the type implementsAsRef<Path>, the borrowed type will too.I feel that it's more natural, since you can then give a
String, a&str, which avoids things likeread(&"my_file.txt")instead ofread("my_file.txt").What do you think?