Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ubuntu:22.04 to ubuntu:24.04 #122

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RuoqingHe
Copy link
Contributor

Summary of the PR

Our downstream are upgrading to Ubuntu 24.04, propose to catch up.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@RuoqingHe
Copy link
Contributor Author

It looks like there are some problems with our CI, and I couldn't find /dev/.buildkit_qemu_emulator anywhere 🧐

@RuoqingHe
Copy link
Contributor Author

Good news, thanks to @roypat's advice, cargo-audit is passing; bad news, cargo-fuzz is failing 😂

See https://github.com/TimePrinciple/rust-vmm-container/actions/runs/13375316552/job/37353170361?pr=2

@stefano-garzarella
Copy link
Member

@RuoqingHe can we close this or it's something we want to explore?

@RuoqingHe
Copy link
Contributor Author

RuoqingHe commented Feb 18, 2025

@RuoqingHe can we close this or it's something we want to explore?

Can we keep this, I intended to propose upgrading to 24.04, maybe this is a bit early, but 22.04 will meet its EOL anyway 🥺

I will update the commit tomorrow

@roypat
Copy link
Collaborator

roypat commented Feb 18, 2025

this reminds me that I still need to look into upgrading the CI hosts to ubuntu 24 as well at some point haha

@RuoqingHe RuoqingHe force-pushed the upgrade-to-ubuntu-24.04 branch from f50f1c0 to 2037aa0 Compare February 19, 2025 01:07
Our downstream are upgrading to Ubuntu 24.04, propose to catch up here.

Update the package list for Ubuntu 24.04.

Signed-off-by: Ruoqing He <[email protected]>
@RuoqingHe RuoqingHe force-pushed the upgrade-to-ubuntu-24.04 branch from 2037aa0 to 57e032c Compare February 19, 2025 01:12
Remove work around required for building dev image for `aarch64`
architecture, introduced in commit 538dba3.

This is address by ubuntu:24:04.

Signed-off-by: Ruoqing He <[email protected]>
`/run/dbus` is created in advance on `riscv64`, adding `p` flag for
`mkdir`.

Signed-off-by: Ruoqing He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants